Bug 82852 – perf-o-matic should store test results' units

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

perf-o-matic should store test results' units

[Ryosuke Niwa]

Created attachment 135024 [details]
Patch

[Ryosuke Niwa]

We don't show units on the frontend yet since I need to make that change in the upstream graph sever code.

[Kentaro Hara]

Comment on attachment 135024 [details]
Patch

Looks OK. Thank you very much for fixing this.

[Ryosuke Niwa]

Thanks for the review!

[Ryosuke Niwa]

Committed r112829: <http://trac.webkit.org/changeset/112829>

[Balazs Ankes]

It broke 2 webkitpy unittest:

FAILURE: webkitpy.performance_tests.perftestsrunner_unittest.MainTest.test_run_test_set_with_json_output
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py", line 227, in test_run_test_set_with_json_output
    "webkit-revision": 5678})
AssertionError: {u'timestamp': 123456789, u'results': {u'group_name:test_name': 42.0, u'Bindings/event-target-wrapper': {u'min': 1471.0, u'max': 1510.0, u'median': 1487.0, u'stdev': 14.460000000000001, u'avg': 1489.05, u'unit': u'ms'}}, u'webkit-revision': 5678} != {'timestamp': 123456789, 'results': {'group_name:test_name': 42, 'Bindings/event-target-wrapper': {'max': 1510, 'avg': 1489.05, 'median': 1487, 'stdev': 14.460000000000001, 'min': 1471}}, 'webkit-revision': 5678}

================================================================================
FAILURE: webkitpy.performance_tests.perftestsrunner_unittest.MainTest.test_run_test_set_with_json_source
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py", line 247, in test_run_test_set_with_json_source
    "key": "value"})
AssertionError: {u'timestamp': 123456789, u'results': {u'group_name:test_name': 42.0, u'Bindings/event-target-wrapper': {u'min': 1471.0, u'max': 1510.0, u'median': 1487.0, u'stdev': 14.460000000000001, u'avg': 1489.05, u'unit': u'ms'}}, u'key': u'value', u'webkit-revision': 5678} != {'timestamp': 123456789, 'results': {'group_name:test_name': 42, 'Bindings/event-target-wrapper': {'max': 1510, 'avg': 1489.05, 'median': 1487, 'stdev': 14.460000000000001, 'min': 1471}}, 'key': 'value', 'webkit-revision': 5678}

[Ryosuke Niwa]

I thought I fixed in http://trac.webkit.org/changeset/112836?