Bug 82852 - perf-o-matic should store test results' units
Summary: perf-o-matic should store test results' units
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037 83294
  Show dependency tree / graph
 
Reported: 2012-04-01 21:19 PDT by Ryosuke Niwa
Modified: 2012-04-05 10:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.57 KB, patch)
2012-04-01 21:28 PDT, Ryosuke Niwa 		haraken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-04-01 21:19:58 PDT 
perf-o-matic should store test results' units
Comment 1 Ryosuke Niwa 2012-04-01 21:28:37 PDT 
Created attachment 135024 [details]
Patch
Comment 2 Ryosuke Niwa 2012-04-01 21:31:00 PDT 
We don't show units on the frontend yet since I need to make that change in the upstream graph sever code.
Comment 3 Kentaro Hara 2012-04-01 21:42:36 PDT 
Comment on attachment 135024 [details]
Patch

Looks OK. Thank you very much for fixing this.
Comment 4 Ryosuke Niwa 2012-04-01 21:43:52 PDT 
Thanks for the review!
Comment 5 Ryosuke Niwa 2012-04-01 21:48:42 PDT 
Committed r112829: <http://trac.webkit.org/changeset/112829>
Comment 6 Balazs Ankes 2012-04-02 01:26:29 PDT 
It broke 2 webkitpy unittest:

FAILURE: webkitpy.performance_tests.perftestsrunner_unittest.MainTest.test_run_test_set_with_json_output
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py", line 227, in test_run_test_set_with_json_output
    "webkit-revision": 5678})
AssertionError: {u'timestamp': 123456789, u'results': {u'group_name:test_name': 42.0, u'Bindings/event-target-wrapper': {u'min': 1471.0, u'max': 1510.0, u'median': 1487.0, u'stdev': 14.460000000000001, u'avg': 1489.05, u'unit': u'ms'}}, u'webkit-revision': 5678} != {'timestamp': 123456789, 'results': {'group_name:test_name': 42, 'Bindings/event-target-wrapper': {'max': 1510, 'avg': 1489.05, 'median': 1487, 'stdev': 14.460000000000001, 'min': 1471}}, 'webkit-revision': 5678}

================================================================================
FAILURE: webkitpy.performance_tests.perftestsrunner_unittest.MainTest.test_run_test_set_with_json_source
--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py", line 247, in test_run_test_set_with_json_source
    "key": "value"})
AssertionError: {u'timestamp': 123456789, u'results': {u'group_name:test_name': 42.0, u'Bindings/event-target-wrapper': {u'min': 1471.0, u'max': 1510.0, u'median': 1487.0, u'stdev': 14.460000000000001, u'avg': 1489.05, u'unit': u'ms'}}, u'key': u'value', u'webkit-revision': 5678} != {'timestamp': 123456789, 'results': {'group_name:test_name': 42, 'Bindings/event-target-wrapper': {'max': 1510, 'avg': 1489.05, 'median': 1487, 'stdev': 14.460000000000001, 'min': 1471}}, 'key': 'value', 'webkit-revision': 5678}
Comment 7 Ryosuke Niwa 2012-04-02 10:06:30 PDT 
I thought I fixed in http://trac.webkit.org/changeset/112836?