Bug 82842 – perf-o-matic should have a way to hide some platforms and tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Ryosuke Niwa]

DeprecatedQt and Bindings/dom_attributes_id_getter for example should be hidden from the dashboard and the list of platforms and tests on the custom chart page.

[Ryosuke Niwa]

I'm not adding an ability to delete things because deleting model objects is very slow on the app engine, and I'd rather not permanently delete objects just yet.

[Ryosuke Niwa]

Created attachment 134989 [details]
Adds the feature

[Ryosuke Niwa]

Created attachment 134990 [details]
Screenshot of the admin page

[Hajime Morrita]

Comment on attachment 134989 [details]
Adds the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=134989&action=review

> Websites/webkit-perf.appspot.com/admin_handlers.py:101
> +            self.response.out.write("Failed to parse the payload: %s" % self.request.body)

Would be nice to set some HTTP error code.

> Websites/webkit-perf.appspot.com/admin_handlers.py:109
> +            self.response.out.write('Not supported')

Ditto

> Websites/webkit-perf.appspot.com/admin_handlers.py:113
> +            self.response.out.write('Could not find the model')

Ditto.

> Websites/webkit-perf.appspot.com/js/admin.js:1
> +function submitXHR(method, action, payload, callback) {

It looks you can just use $.ajax
http://api.jquery.com/jQuery.ajax/

[Ryosuke Niwa]

(In reply to comment #4)
> (From update of attachment 134989 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134989&action=review
> 
> > Websites/webkit-perf.appspot.com/admin_handlers.py:101
> > +            self.response.out.write("Failed to parse the payload: %s" % self.request.body)
> 
> Would be nice to set some HTTP error code.

Admin page, like other perf-o-matic pages, check the response text and shows an error dialog when it's not equal to 'OK'. If we're making that change, it should be a separate patch. Also, it likely requires an upstream change if we wanted to be consistent.

> > Websites/webkit-perf.appspot.com/js/admin.js:1
> > +function submitXHR(method, action, payload, callback) {
> 
> It looks you can just use $.ajax
> http://api.jquery.com/jQuery.ajax/

It doesn't provide a good API to get the http status code out :(

[Hajime Morrita]

Comment on attachment 134989 [details]
Adds the feature

okay.

[WebKit Review Bot]

Comment on attachment 134989 [details]
Adds the feature

Clearing flags on attachment: 134989

Committed r112822: <http://trac.webkit.org/changeset/112822>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.