Bug 82819 – search field on Google.com does not have the AXSearchField subrole

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Search fields do not have the AXSubrole: AXSearchField

[chris fleizach]

Created attachment 134948 [details]
patch

[Darin Adler]

Comment on attachment 134948 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134948&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:506
> +    // Some websites don't label their search fields as search, so we should fallback to some heuristics.

This comment doesn’t explain why these heuristics are helpful. Nor why these heuristics are sufficient.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:508
> +    String nameAttribute = getAttribute(nameAttr);

const AtomicString& nameAttribute = fastGetAttribute(nameAttr);

> LayoutTests/platform/mac/accessibility/search-subrole-expected.txt:15
> +PASS nosearch.subrole is 'AXSubrole: '

Could use more coverage for the negative. For example, an element that is not in any form.

Need coverage for the “not case sensitive” aspect. All these are all lowercase so the “false” for case sensitive is not tested at all.

[chris fleizach]

http://trac.webkit.org/changeset/112989