Created attachment 134919 [details] Make WebKit work with composite font references <rdar://problem/10717370> When an NSFont is composed of multiple fonts, rather than representing a single CGFont, WebKit doesn’t render it correctly. Attaching a patch from another contributor, which addresses this issue.
Created attachment 134921 [details] Make WebKit work with composite font references
Attachment 134921 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:139: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/WebCore/ChangeLog:28: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 5 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 134923 [details] Make WebKit work with composite font references
Attachment 134923 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/ChangeLog:29: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134923 [details] Make WebKit work with composite font references Attachment 134923 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12267573 New failing tests: fast/text/international/text-spliced-font.html
Created attachment 134933 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
(In reply to comment #5) > New failing tests: > fast/text/international/text-spliced-font.html This is a new test from this patch.
Fixed in <http://trac.webkit.org/r112767>.
Looks like this broke the Chromium Mac build ... I expect it will probably break the Apple Mac builds shortly. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder/builds/21403/steps/compile/logs/stdio#error1
(In reply to comment #9) > Looks like this broke the Chromium Mac build ... I expect it will probably break the Apple Mac builds shortly. > > http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder/builds/21403/steps/compile/logs/stdio#error1 I am looking into this now.
Tried to fix the Chromium Mac build in <http://trac.webkit.org/r112770>.
This caused a lot of new test failures: http://build.webkit.org/results/Lion%20Release%20(Tests)/r112767%20(7070)/results.html
(In reply to comment #12) > This caused a lot of new test failures: > http://build.webkit.org/results/Lion%20Release%20(Tests)/r112767%20(7070)/results.html I am going to revert this change ASAP.
Reverted r112770 and r112767 in <http://trac.webkit.org/r112771>.
Fixed in <http://trac.webkit.org/r112816>.