Bug 82786 - Add a compile assert for the size of FontDescription
Summary: Add a compile assert for the size of FontDescription
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 14:58 PDT by Ryosuke Niwa
Modified: 2012-03-30 15:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2012-03-30 15:07 PDT, Ryosuke Niwa 		eric: review+
pnormand: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-30 14:58:54 PDT 
Add a compile assert for the size of FontDescription
Comment 1 Ryosuke Niwa 2012-03-30 15:07:52 PDT 
Created attachment 134895 [details]
Patch
Comment 2 Philippe Normand 2012-03-30 15:24:02 PDT 
Comment on attachment 134895 [details]
Patch

Attachment 134895 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12266544
Comment 3 Eric Seidel (no email) 2012-03-30 15:24:44 PDT 
Comment on attachment 134895 [details]
Patch

Seems reasonable.
Comment 4 Ryosuke Niwa 2012-03-30 15:30:50 PDT 
Comment on attachment 134895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134895&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:42
> +    uint32_t bitfields : 8;

Oops, gotta rename this :(
Comment 5 Ryosuke Niwa 2012-03-30 15:36:13 PDT 
Committed r112736: <http://trac.webkit.org/changeset/112736>