Bug 82780 - Add a compile assert for the size of RenderText
Summary: Add a compile assert for the size of RenderText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 14:24 PDT by Ryosuke Niwa
Modified: 2012-03-30 22:16 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2012-03-30 14:25 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed gtk build (2.19 KB, patch)
2012-03-30 15:01 PDT, Ryosuke Niwa 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Another build fix (2.66 KB, patch)
2012-03-30 15:40 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-30 14:24:59 PDT 
Add a compile assert for the size of RenderText
Comment 1 Ryosuke Niwa 2012-03-30 14:25:48 PDT 
Created attachment 134882 [details]
Patch
Comment 2 Philippe Normand 2012-03-30 14:31:05 PDT 
Comment on attachment 134882 [details]
Patch

Attachment 134882 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12288439
Comment 3 Ryosuke Niwa 2012-03-30 14:35:26 PDT 
As I suspected, we need to re-order floats here.
Comment 4 Ryosuke Niwa 2012-03-30 15:01:50 PDT 
Created attachment 134890 [details]
Fixed gtk build
Comment 5 Early Warning System Bot 2012-03-30 15:24:58 PDT 
Comment on attachment 134890 [details]
Fixed gtk build

Attachment 134890 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12253485
Comment 6 Early Warning System Bot 2012-03-30 15:27:48 PDT 
Comment on attachment 134890 [details]
Fixed gtk build

Attachment 134890 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12262469
Comment 7 WebKit Review Bot 2012-03-30 15:29:00 PDT 
Comment on attachment 134890 [details]
Fixed gtk build

Attachment 134890 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12265492
Comment 8 Build Bot 2012-03-30 15:31:50 PDT 
Comment on attachment 134890 [details]
Fixed gtk build

Attachment 134890 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12265490
Comment 9 Ryosuke Niwa 2012-03-30 15:39:51 PDT 
Oops, I also need to change the order of initialization :(
Comment 10 Ryosuke Niwa 2012-03-30 15:40:04 PDT 
Created attachment 134902 [details]
Another build fix
Comment 11 Dirk Pranke 2012-03-30 21:50:26 PDT 
Comment on attachment 134902 [details]
Another build fix

View in context: https://bugs.webkit.org/attachment.cgi?id=134902&action=review

> Source/WebCore/ChangeLog:8
> +        Added an assertion.

You should probably note that you moved fields around as well ...
Comment 12 Ryosuke Niwa 2012-03-30 22:16:40 PDT 
Committed r112776: <http://trac.webkit.org/changeset/112776>