WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 82771
Remove dead code behind ENSURE_VALUE_SAFETY_FOR_SKIA flag
https://bugs.webkit.org/show_bug.cgi?id=82771
Summary
Remove dead code behind ENSURE_VALUE_SAFETY_FOR_SKIA flag
Mike Reed
Reported
2012-03-30 12:42:06 PDT
Remove deadcode behind "SafeSkia" flag
Attachments
Patch
(14.17 KB, patch)
2012-03-30 12:44 PDT
,
Mike Reed
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike Reed
Comment 1
2012-03-30 12:44:28 PDT
Created
attachment 134864
[details]
Patch
Mike Reed
Comment 2
2012-03-30 12:45:23 PDT
According to the comment, ENSURE_VALUE_SAFETY_FOR_SKIA has not been defined for over 2 years, so for the sake of readability, I wanted to remove it and the (dead) code it was bracketing.
Stephen White
Comment 3
2012-03-30 13:36:55 PDT
Damn, I was going to have our intern do this as his first task. :)
Stephen White
Comment 4
2012-03-30 13:39:17 PDT
Comment on
attachment 134864
[details]
Patch Awesome. r=me
WebKit Review Bot
Comment 5
2012-03-30 14:16:56 PDT
Comment on
attachment 134864
[details]
Patch Clearing flags on attachment: 134864 Committed
r112726
: <
http://trac.webkit.org/changeset/112726
>
WebKit Review Bot
Comment 6
2012-03-30 14:17:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug