Bug 82761 - fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadGrammarInRanges()
Summary: fast/forms/search-event-delay.html is asserting in markAllMisspellingsAndBadG...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 85273 96012 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-30 11:40 PDT by Simon Fraser (smfr)
Modified: 2012-09-18 15:44 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2012-09-18 15:17 PDT, Simon Fraser (smfr)
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-03-30 11:40:45 PDT
Test is hitting this on the bots:

ASSERTION FAILED: unifiedTextCheckerEnabled()
/Volumes/Data/slave/lion-intel-debug/build/Source/WebCore/editing/Editor.cpp(1911) : void WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask, WebCore::Range *, WebCore::Range *)
1   0x10ac62b53 WebCore::SpellingCorrectionController::correctionPanelTimerFired(WebCore::Timer<WebCore::SpellingCorrectionController>*)
2   0x10ac66fe3 WebCore::Timer<WebCore::SpellingCorrectionController>::fired()
3   0x10ae6e107 WebCore::ThreadTimers::sharedTimerFiredInternal()
4   0x10ae6de49 WebCore::ThreadTimers::sharedTimerFired()
5   0x10ac34483 _ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv
6   0x7fff8bbbec24 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
7   0x7fff8bbbe776 __CFRunLoopDoTimer
8   0x7fff8bb9f001 __CFRunLoopRun
9   0x7fff8bb9e676 CFRunLoopRunSpecific
10  0x7fff89940f9f -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
11  0x1082657b9 _ZL7runTestRKNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE
12  0x1082640aa _ZL20runTestingServerLoopv
13  0x108263919 dumpRenderTree(int, char const**)
14  0x10826601c main
15  0x10824f364 start
Comment 1 Radar WebKit Bug Importer 2012-03-30 17:40:33 PDT
<rdar://problem/11159937>
Comment 2 Simon Fraser (smfr) 2012-03-30 17:44:40 PDT
I'm adding ASSERT(m_frame) to see if that's the issue.
Comment 3 Simon Fraser (smfr) 2012-09-18 14:42:27 PDT
I think DRT and WTR need to reset the 'unifiedTextCheckingEnabled' pref between tests.
Comment 4 Simon Fraser (smfr) 2012-09-18 15:03:21 PDT
*** Bug 96012 has been marked as a duplicate of this bug. ***
Comment 5 Simon Fraser (smfr) 2012-09-18 15:04:10 PDT
*** Bug 85273 has been marked as a duplicate of this bug. ***
Comment 6 Simon Fraser (smfr) 2012-09-18 15:17:59 PDT
Created attachment 164627 [details]
Patch
Comment 7 Ryosuke Niwa 2012-09-18 15:35:49 PDT
Comment on attachment 164627 [details]
Patch

Looks reasonable.
Comment 8 Simon Fraser (smfr) 2012-09-18 15:44:46 PDT
http://trac.webkit.org/changeset/128941