Bug 82756 - Add a compile assert for the size of CSSProperty
Summary: Add a compile assert for the size of CSSProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 11:10 PDT by Ryosuke Niwa
Modified: 2012-03-30 11:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (4.54 KB, patch)
2012-03-30 11:11 PDT, Ryosuke Niwa 		kling: review+
pnormand: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-30 11:10:19 PDT 
Add a compile assert for the size of CSSProperty
Comment 1 Ryosuke Niwa 2012-03-30 11:11:32 PDT 
Created attachment 134841 [details]
Patch
Comment 2 Andreas Kling 2012-03-30 11:15:52 PDT 
Comment on attachment 134841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134841&action=review

r=me

> Source/WebCore/css/CSSProperty.h:60
> +private:

Whoa. Great change.
Comment 3 Ojan Vafai 2012-03-30 11:17:44 PDT 
Comment on attachment 134841 [details]
Patch

This patch does a lot more than just add a compile assert! Please add descriptions for the other changes (wrapValue && bool-->unsigned && making member variables private).
Comment 4 Philippe Normand 2012-03-30 11:21:45 PDT 
Comment on attachment 134841 [details]
Patch

Attachment 134841 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12266417
Comment 5 Ryosuke Niwa 2012-03-30 11:27:22 PDT 
Committed r112699: <http://trac.webkit.org/changeset/112699>