Bug 82754 – video doesn't display when <video> size is same as video resource size

• Status: NEW
• Component: Media

There is no video display when the following sequence is done:
1. The page has
<video width="640" height="480" id="videoView" autoplay="autoplay"></video> 

2. Later on, JS update <video>'s src as
document.getElementById("videoView").src = VGA.mp4
where VGA.mp4 has video frame size as 640x480.

Scaling the browser window enables video display.

It appears that RenderVideo doesn't request re-layout since poster frame has same width/height as video resource.

Created attachment 134843 [details]
Patch

[WebKit Review Bot]

Attachment 134843 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 134843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134843&action=review

Marking r- because this needs a test.

>> Source/WebCore/ChangeLog:8
>> +        No new tests. (OOPS!)
> 
> You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]

It is definitely worth creating a test for this!

> Source/WebCore/rendering/RenderVideo.cpp:129
> +        if (!size.isEmpty()) {
> +            if (!m_hasVideoSourceSize) {
> +                m_hasVideoSourceSize = true;
> +                m_forceUpdateIntrinsicSize = true;
> +            }
>              return size;
> +        }

Instead of using two bools, you could use a single enum. Something like:

enum IntrinsicSizeUpdateRequired { None, Pending, Done };

if (!size.isEmpty()) {
    if (m_intrinsicSizeUpdateRequired == None)
        m_intrinsicSizeUpdateRequired = Pending;
    ...

etc.