Bug 82753 - Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method for InspectorObject
Summary: Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 10:52 PDT by Peter Rybin
Modified: 2012-03-30 11:54 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.77 KB, patch)
2012-03-30 11:02 PDT, Peter Rybin
no flags Details | Formatted Diff | Diff
Patch (6.77 KB, patch)
2012-03-30 11:33 PDT, Peter Rybin
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-03-30 10:52:55 PDT
Do not allow InspectorObject and other raw interfaces from Console and DOMDebugger domains anymore.
Comment 1 Peter Rybin 2012-03-30 11:02:14 PDT
Created attachment 134840 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-30 11:19:40 PDT
Comment on attachment 134840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134840&action=review

> Source/WebCore/ChangeLog:10
> +        Type validator generator is extended to support missing InspectorObject type and

Looks like this is main thing done in this patch. Could you please name the bug accordignly?
Comment 3 Peter Rybin 2012-03-30 11:28:18 PDT
Among all types that needs assert for runtime validator, InspectorObject is missing and should be also supported.
Switching Console and DOMDebugger to strict typed api reduces to more of a drive-by fix.
Comment 4 Peter Rybin 2012-03-30 11:33:11 PDT
Created attachment 134846 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-03-30 11:54:23 PDT
Committed r112706: <http://trac.webkit.org/changeset/112706>