Bug 82751 – http/tests/security/cross-frame-access-put.html is failing

Bug 82751 - http/tests/security/cross-frame-access-put.html is failing


Summary:	http/tests/security/cross-frame-access-put.html is failing

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	Chris Dumez

URL:
Keywords:	InRadar

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-30 10:50 PDT by Simon Fraser (smfr)
Modified:	2012-05-06 22:53 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (1.80 KB, patch) 2012-04-26 00:24 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Patch (132.31 KB, patch) 2012-04-26 00:44 PDT, Chris Dumez	haraken: review+ ap: commit‑queue-	Details \| Formatted Diff \| Diff
Patch (132.40 KB, patch) 2012-04-26 01:56 PDT, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2012-03-30 10:50:59 PDT

http://build.webkit.org/results/Lion%20Debug%20(Tests)/r112674%20(5107)/results.html

Comment 1 Alexey Proskuryakov 2012-04-01 00:56:08 PDT

This link is 404.

Comment 2 Radar WebKit Bug Importer 2012-04-01 00:56:45 PDT

<rdar://problem/11162572>

Comment 3 Alexey Proskuryakov 2012-04-02 10:10:39 PDT

-ALERT: PASS: window.frameElement should be 'undefined' and is.
+ALERT: PASS: window.frameElement should be 'null' and is.

Looks like results just need to be updated per bug 80205. That bug updated chromium and Gtk, but for some reason not cross-platform or Qt.

Comment 4 Chris Dumez 2012-04-26 00:06:31 PDT

Yes, we have a similar issue in the EFL port.

bug 80205 has not updated the following global expectation:
LayoutTests/http/tests/security/cross-frame-access-put-expected.txt

Comment 5 Chris Dumez 2012-04-26 00:24:33 PDT

Created attachment 138948 [details]
Patch

Proposing patch to update global expected result for http/tests/security/cross-frame-access-put.html test. The value of window.frameElement is now 'null' instead of 'undefined' when shouldAllowAccessToNode() check fails, after bug 80205 fix.

- This fixes the test for EFL port which does not have platform-specific expectation.
- GTK, Qt, Chromium ports have platform-specific expectations and have already been updated.
- The test is skipped on wincairo, qt-mac, qt-arm, wk2, win and mac.

Comment 6 Chris Dumez 2012-04-26 00:44:58 PDT

Created attachment 138949 [details]
Patch

Update patch to remove Qt/GTK-specific expectations now they are identical to the global one.

Comment 7 Kentaro Hara 2012-04-26 01:39:52 PDT

Comment on attachment 138949 [details]
Patch

Thank you very much for the rebaselining!

Comment 8 Alexey Proskuryakov 2012-04-26 01:41:09 PDT

Comment on attachment 138949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138949&action=review

> LayoutTests/ChangeLog:14
> +        * http/tests/security/cross-frame-access-put-expected.txt:

The ChangeLog needs to be regenerated to list deleted files. You can also move comments from above to make them per-file.

Comment 9 Chris Dumez 2012-04-26 01:56:03 PDT

Created attachment 138955 [details]
Patch

Update Changelog as per AP's recommendation.

Comment 10 WebKit Review Bot 2012-04-26 03:26:59 PDT

Comment on attachment 138955 [details]
Patch

Clearing flags on attachment: 138955

Committed r115299: <http://trac.webkit.org/changeset/115299>

Comment 11 WebKit Review Bot 2012-04-26 03:27:04 PDT

All reviewed patches have been landed.  Closing bug.