WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82733
Web Inspector: undo-ing edit that consists of a Tab does not work.
https://bugs.webkit.org/show_bug.cgi?id=82733
Summary
Web Inspector: undo-ing edit that consists of a Tab does not work.
Pavel Feldman
Reported
2012-03-30 08:39:36 PDT
We should never modify the range returned by the edit operation manually. And we should clone ranges that get into the model so that subsequent edits don't mutate them.
Attachments
Patch
(5.22 KB, patch)
2012-03-30 08:48 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(5.36 KB, patch)
2012-03-30 09:15 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
[Patch] with selection restored
(5.76 KB, patch)
2012-03-30 09:21 PDT
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-03-30 08:48:43 PDT
Created
attachment 134820
[details]
Patch
Vsevolod Vlasov
Comment 2
2012-03-30 09:11:44 PDT
Comment on
attachment 134820
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=134820&action=review
> Source/WebCore/inspector/front-end/TextViewer.js:1134 > + newRange.startColumn = newRange.endColumn;
I think this is not supposed to happen in some of the code flows above.
Pavel Feldman
Comment 3
2012-03-30 09:15:24 PDT
Created
attachment 134823
[details]
Patch
Pavel Feldman
Comment 4
2012-03-30 09:21:42 PDT
Created
attachment 134826
[details]
[Patch] with selection restored
Pavel Feldman
Comment 5
2012-03-30 09:24:56 PDT
Committed
r112674
: <
http://trac.webkit.org/changeset/112674
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug