Bug 82731 – [chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Synchronized start times may be compared before synchronization has actually happened. Need to move this comparison into notifyAnimationStarted.

Created attachment 134809 [details]
Patch

[James Robinson]

Comment on attachment 134809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review

R=me, but you don't need this extra pointer.

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069
> +        , m_layerTreeHostImpl(0)

you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest).

(In reply to comment #2)
> (From update of attachment 134809 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review
> 
> R=me, but you don't need this extra pointer.
> 
> > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069
> > +        , m_layerTreeHostImpl(0)
> 
> you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest).

I wasn't sure if there was a way to get the CCLayerTreeHostImpl associated with the CCLayerTreeHost obtained from layerTreeHost(). My best thought was to grab a pointer to it from one of the test hooks. Is there a better way?

[James Robinson]

Oh sorry, I misread (haven't woken up yet I suppose).  Your approach seems good.

[WebKit Review Bot]

Comment on attachment 134809 [details]
Patch

Clearing flags on attachment: 134809

Committed r112708: <http://trac.webkit.org/changeset/112708>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.