RESOLVED FIXED 82731
[chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=82731
Summary [chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationS...
vollick
Reported 2012-03-30 07:24:32 PDT
Synchronized start times may be compared before synchronization has actually happened. Need to move this comparison into notifyAnimationStarted.
Attachments
Patch (2.86 KB, patch)
2012-03-30 07:27 PDT, vollick
no flags
vollick
Comment 1 2012-03-30 07:27:38 PDT
James Robinson
Comment 2 2012-03-30 10:37:04 PDT
Comment on attachment 134809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review R=me, but you don't need this extra pointer. > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > + , m_layerTreeHostImpl(0) you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest).
vollick
Comment 3 2012-03-30 10:51:41 PDT
(In reply to comment #2) > (From update of attachment 134809 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134809&action=review > > R=me, but you don't need this extra pointer. > > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1069 > > + , m_layerTreeHostImpl(0) > > you don't need this, there's already a public layerTreeHost() getter on your grand-father class (CCLayerTreeHostTest). I wasn't sure if there was a way to get the CCLayerTreeHostImpl associated with the CCLayerTreeHost obtained from layerTreeHost(). My best thought was to grab a pointer to it from one of the test hooks. Is there a better way?
James Robinson
Comment 4 2012-03-30 10:55:50 PDT
Oh sorry, I misread (haven't woken up yet I suppose). Your approach seems good.
WebKit Review Bot
Comment 5 2012-03-30 12:06:15 PDT
Comment on attachment 134809 [details] Patch Clearing flags on attachment: 134809 Committed r112708: <http://trac.webkit.org/changeset/112708>
WebKit Review Bot
Comment 6 2012-03-30 12:06:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.