Bug 82729 - [GTK] Disable introspection build in the at-spi2-core module
Summary: [GTK] Disable introspection build in the at-spi2-core module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vineet Chaudhary (vineetc)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 06:58 PDT by Vineet Chaudhary (vineetc)
Modified: 2012-03-30 09:19 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (1.22 KB, patch)
2012-03-30 07:03 PDT, Vineet Chaudhary (vineetc)
pnormand: review-
Details | Formatted Diff | Diff
Updated Patch (1.22 KB, patch)
2012-03-30 07:19 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff
Patch (1.26 KB, patch)
2012-03-30 07:24 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff
another_attempt (1.27 KB, patch)
2012-03-30 07:37 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vineet Chaudhary (vineetc) 2012-03-30 06:58:32 PDT
jhbuild is failing on linux(ubuntu).
Filing bug as per discussion on IRC with philn-tp.
Comment 1 Vineet Chaudhary (vineetc) 2012-03-30 07:03:05 PDT
Created attachment 134801 [details]
proposed patch

proposed patch.
Comment 2 Philippe Normand 2012-03-30 07:15:40 PDT
Comment on attachment 134801 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review

Looks good indeed but the ChangeLog just needs a little update.

> Tools/ChangeLog:3
> +        Introspections needs to be disable for "at-spi2-core" module

Can you use the updated bug title please?

> Tools/ChangeLog:9
> +        Fixes jhbuild issue for gtk.
> +        Disabling Introspection for at-spi2-core module.

Just mention that this change is a follow-up of bug 82395 which initially disabled for other modules of the set.
Comment 3 Gustavo Noronha (kov) 2012-03-30 07:19:26 PDT
Comment on attachment 134801 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review

> Tools/gtk/jhbuild.modules:175
> +  <autotools id="at-spi2-core" autogenargs="--disable-introspection">

If you can put the autogenargs in a new line, aligned with id like the other modules that would be great =)
Comment 4 Vineet Chaudhary (vineetc) 2012-03-30 07:19:45 PDT
Created attachment 134805 [details]
Updated Patch

Done Thanks..
Comment 5 Vineet Chaudhary (vineetc) 2012-03-30 07:24:26 PDT
Created attachment 134807 [details]
Patch

Sorry I was too quick.. :)
Comment 6 Philippe Normand 2012-03-30 07:31:44 PDT
Comment on attachment 134807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134807&action=review

> Tools/gtk/jhbuild.modules:176
> +  <autotools id="at-spi2-core" 
> +            autogenargs="--disable-introspection">

Doesn't seem to be aligned with the id=
Comment 7 Vineet Chaudhary (vineetc) 2012-03-30 07:37:41 PDT
Created attachment 134812 [details]
another_attempt
Comment 8 Philippe Normand 2012-03-30 07:52:45 PDT
Comment on attachment 134812 [details]
another_attempt

Thanks :)
Comment 9 WebKit Review Bot 2012-03-30 09:18:56 PDT
Comment on attachment 134812 [details]
another_attempt

Clearing flags on attachment: 134812

Committed r112672: <http://trac.webkit.org/changeset/112672>
Comment 10 WebKit Review Bot 2012-03-30 09:19:00 PDT
All reviewed patches have been landed.  Closing bug.