jhbuild is failing on linux(ubuntu). Filing bug as per discussion on IRC with philn-tp.
Created attachment 134801 [details] proposed patch proposed patch.
Comment on attachment 134801 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review Looks good indeed but the ChangeLog just needs a little update. > Tools/ChangeLog:3 > + Introspections needs to be disable for "at-spi2-core" module Can you use the updated bug title please? > Tools/ChangeLog:9 > + Fixes jhbuild issue for gtk. > + Disabling Introspection for at-spi2-core module. Just mention that this change is a follow-up of bug 82395 which initially disabled for other modules of the set.
Comment on attachment 134801 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review > Tools/gtk/jhbuild.modules:175 > + <autotools id="at-spi2-core" autogenargs="--disable-introspection"> If you can put the autogenargs in a new line, aligned with id like the other modules that would be great =)
Created attachment 134805 [details] Updated Patch Done Thanks..
Created attachment 134807 [details] Patch Sorry I was too quick.. :)
Comment on attachment 134807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134807&action=review > Tools/gtk/jhbuild.modules:176 > + <autotools id="at-spi2-core" > + autogenargs="--disable-introspection"> Doesn't seem to be aligned with the id=
Created attachment 134812 [details] another_attempt
Comment on attachment 134812 [details] another_attempt Thanks :)
Comment on attachment 134812 [details] another_attempt Clearing flags on attachment: 134812 Committed r112672: <http://trac.webkit.org/changeset/112672>
All reviewed patches have been landed. Closing bug.