RESOLVED FIXED 82729
[GTK] Disable introspection build in the at-spi2-core module 
https://bugs.webkit.org/show_bug.cgi?id=82729
Summary [GTK] Disable introspection build in the at-spi2-core module
Vineet Chaudhary (vineetc)
Reported 2012-03-30 06:58:32 PDT
jhbuild is failing on linux(ubuntu). Filing bug as per discussion on IRC with philn-tp.
Attachments
proposed patch (1.22 KB, patch)
2012-03-30 07:03 PDT, Vineet Chaudhary (vineetc) 		pnormand: review-
DetailsFormatted DiffDiff
Updated Patch (1.22 KB, patch)
2012-03-30 07:19 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2012-03-30 07:24 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
another_attempt (1.27 KB, patch)
2012-03-30 07:37 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vineet Chaudhary (vineetc)
Comment 1 2012-03-30 07:03:05 PDT
Created attachment 134801 [details] proposed patch proposed patch.
Philippe Normand
Comment 2 2012-03-30 07:15:40 PDT
Comment on attachment 134801 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review Looks good indeed but the ChangeLog just needs a little update. > Tools/ChangeLog:3 > + Introspections needs to be disable for "at-spi2-core" module Can you use the updated bug title please? > Tools/ChangeLog:9 > + Fixes jhbuild issue for gtk. > + Disabling Introspection for at-spi2-core module. Just mention that this change is a follow-up of bug 82395 which initially disabled for other modules of the set.
Gustavo Noronha (kov)
Comment 3 2012-03-30 07:19:26 PDT
Comment on attachment 134801 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review > Tools/gtk/jhbuild.modules:175 > + <autotools id="at-spi2-core" autogenargs="--disable-introspection"> If you can put the autogenargs in a new line, aligned with id like the other modules that would be great =)
Vineet Chaudhary (vineetc)
Comment 4 2012-03-30 07:19:45 PDT
Created attachment 134805 [details] Updated Patch Done Thanks..
Vineet Chaudhary (vineetc)
Comment 5 2012-03-30 07:24:26 PDT
Created attachment 134807 [details] Patch Sorry I was too quick.. :)
Philippe Normand
Comment 6 2012-03-30 07:31:44 PDT
Comment on attachment 134807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134807&action=review > Tools/gtk/jhbuild.modules:176 > + <autotools id="at-spi2-core" > + autogenargs="--disable-introspection"> Doesn't seem to be aligned with the id=
Vineet Chaudhary (vineetc)
Comment 7 2012-03-30 07:37:41 PDT
Created attachment 134812 [details] another_attempt
Philippe Normand
Comment 8 2012-03-30 07:52:45 PDT
Comment on attachment 134812 [details] another_attempt Thanks :)
WebKit Review Bot
Comment 9 2012-03-30 09:18:56 PDT
Comment on attachment 134812 [details] another_attempt Clearing flags on attachment: 134812 Committed r112672: <http://trac.webkit.org/changeset/112672>
WebKit Review Bot
Comment 10 2012-03-30 09:19:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.