Bug 82725 – REGRESSION(r112489): Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit).

• Status: REOPENED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/112489 broke the build:
Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 134792 [details]
ROLLOUT of r112489

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Kenichi Ishibashi]

(In reply to comment #0)
> http://trac.webkit.org/changeset/112489 broke the build:
> Tentatively introduces a lot of webfont-related test flakiness on Snow Leopard (Requested by apavlov on #webkit).
> 
> This is an automatic bug report generated by the sheriff-bot. If this bug
> report was created because of a flaky test, please file a bug for the flaky
> test (if we don't already have one on file) and dup this bug against that bug
> so that we can track how often these flaky tests case pain.
> 
> "Only you can prevent forest fires." -- Smokey the Bear

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fcanvas%2F2d.text.draw.fill.maxWidth.gradient.html%2Cfast%2Fcss%2Ffont-face-insert-link.html%2Ccompositing%2Fgeometry%2Fempty-embed-rects.html%2Ccompositing%2Fgeometry%2Fobject-clip-rects-assertion.html%2Ccss2.1%2F20110323%2Fblock-non-replaced-height-005.htm%2Ccss2.1%2Ft0805-c5518-brdr-t-01-e.html%2Ccss2.1%2Ft1503-c522-font-family-00-b.html%2Ccss3%2Fselectors3%2Fhtml%2Fcss3-modsel-64.html%2Ccss3%2Fselectors3%2Fxhtml%2Fcss3-modsel-64.xml%2Ccss3%2Fselectors3%2Fxml%2Fcss3-modsel-64.xml%2Cediting%2Fdeleting%2Fdelete-first-list-item.html%2Cediting%2FexecCommand%2Fprint.html%2Cediting%2Finserting%2Finsert-3851164-fix.html%2Cediting%2Fpasteboard%2Fdrop-text-without-selection.html%2Cediting%2Fselection%2F3690703-2.html%2Cediting%2Fselection%2Fvertical-lr-ltr-extend-line-backward-br.html%2Cediting%2Fstyle%2F5017613-1.html%2Cfast%2Fcss%2Ffont-face-woff.html%2Cfast%2Fforms%2Fbasic-textareas-quirks.html%2Cfast%2Fimages%2Fembed-does-not-propagate-dimensions-to-object-ancestor.html%2Chttp%2Ftests%2Fappcache%2Fremove-cache.html%2Chttp%2Ftests%2Fappcache%2Fxhr-foreign-resource.html

I glanced one of the test and noticed it uses timer to wait font loading, it is essentially flaky. I think these tests should be updated.

[WebKit Review Bot]

Comment on attachment 134792 [details]
ROLLOUT of r112489

Clearing flags on attachment: 134792

Committed r112659: <http://trac.webkit.org/changeset/112659>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kenichi Ishibashi]

Even after my patch was rolled out, it looks webfont-related tests are still flaky.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/14337

I don't think my patch is the cause. apalov@, what do you think?

[Alexander Pavlov (apavlov)]

(In reply to comment #5)
> Even after my patch was rolled out, it looks webfont-related tests are still flaky.
> http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/14337
> 
> I don't think my patch is the cause. apalov@, what do you think?

Yes, looks like the culprit was elsewhere.

[Alexey Proskuryakov]

Is this bug still needed?