WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 82724
[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
https://bugs.webkit.org/show_bug.cgi?id=82724
Summary
[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
Mikhail Pozdnyakov
Reported
2012-03-30 05:13:46 PDT
EFL's LayoutTestController needs removeAllVisitedLinks implementation in oreder to unskip http/tests/globalhistory/history-delegate-basic-visited-links.html
Attachments
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
(2.70 KB, patch)
2012-03-30 06:07 PDT
,
Mikhail Pozdnyakov
no flags
Details
Formatted Diff
Diff
rebased
(2.60 KB, patch)
2012-08-06 04:32 PDT
,
Mikhail Pozdnyakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1
2012-03-30 06:07:16 PDT
Created
attachment 134796
[details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
Gyuyoung Kim
Comment 2
2012-03-30 06:36:01 PDT
Comment on
attachment 134796
[details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM.
Mikhail Pozdnyakov
Comment 3
2012-03-30 06:58:41 PDT
(In reply to
comment #2
)
> (From update of
attachment 134796
[details]
) > Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM.
Added a short description of the fix.
Raphael Kubo da Costa (:rakuco)
Comment 4
2012-03-30 12:54:05 PDT
Comment on
attachment 134796
[details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method Looks good.
Gyuyoung Kim
Comment 5
2012-04-02 17:42:48 PDT
Comment on
attachment 134796
[details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method Looks good to me too.
Gyuyoung Kim
Comment 6
2012-07-27 18:41:22 PDT
It looks you need to rebase this patch. Then, please find reviewer on irc.
Mikhail Pozdnyakov
Comment 7
2012-08-06 04:32:20 PDT
Created
attachment 156658
[details]
rebased
Csaba Osztrogonác
Comment 8
2012-08-06 04:55:05 PDT
Comment on
attachment 156658
[details]
rebased rs=me.
WebKit Review Bot
Comment 9
2012-08-06 05:27:19 PDT
Comment on
attachment 156658
[details]
rebased Clearing flags on attachment: 156658 Committed
r124756
: <
http://trac.webkit.org/changeset/124756
>
WebKit Review Bot
Comment 10
2012-08-06 05:27:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug