Bug 82721 - [BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp
Summary: [BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 04:57 PDT by Charles Wei
Modified: 2012-03-31 05:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (3.41 KB, patch)
2012-03-30 05:25 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2012-03-30 23:19 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-30 04:57:00 PDT 
PlatformKeyboardEventBlackBerry.cpp needs to be upstreamed of the following changes:

1. Now the PlatformKeyboardEvent needs a timestamp.
2. Fix the initialization sequence.
3. BackTab as Sift + Tab.
Comment 1 Charles Wei 2012-03-30 05:25:31 PDT 
Created attachment 134790 [details]
Patch v1
Comment 2 WebKit Review Bot 2012-03-30 05:28:35 PDT 
Attachment 134790 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Charles Wei 2012-03-30 23:19:33 PDT 
Created attachment 134946 [details]
Patch
Comment 4 Rob Buis 2012-03-31 05:21:32 PDT 
Comment on attachment 134946 [details]
Patch

Looks good.
Comment 5 Charles Wei 2012-03-31 05:26:10 PDT 
Comment on attachment 134946 [details]
Patch

Thanks for the review, Rob.
Comment 6 WebKit Review Bot 2012-03-31 05:33:17 PDT 
Comment on attachment 134946 [details]
Patch

Clearing flags on attachment: 134946

Committed r112789: <http://trac.webkit.org/changeset/112789>
Comment 7 WebKit Review Bot 2012-03-31 05:33:22 PDT 
All reviewed patches have been landed.  Closing bug.