WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
82718
style bot doesn't complain about wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=82718
Summary
style bot doesn't complain about wrong indentation
jochen
Reported
2012-03-30 04:21:10 PDT
the style bot didn't complain about the diff here:
https://bugs.webkit.org/attachment.cgi?id=134753&action=prettypatch
however, the new code in TextInputFieldType.cpp is not correctly indented (first level is correctly 4 spaces, second level is incorrectly 2 spaces)
Attachments
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2012-03-30 07:52:56 PDT
It is a challenge to fix this one due to the fact that the style checker is not a real parser. it is possible but it requires a bit more parsing to happen in the tool. One day perhaps it would be good to move to a clang based checker like chromium has done.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug