Bug 82706 - Need using namespace std for system calls in MIMESniffing.cpp
Summary: Need using namespace std for system calls in MIMESniffing.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-30 02:08 PDT by Charles Wei
Modified: 2012-04-04 20:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2012-03-30 02:18 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (1.26 KB, patch)
2012-04-04 18:14 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-30 02:08:16 PDT 
Source/WebCore/platform/network/MIMESniffing.cpp uses many libc calls like memcmp, strcmp, etc,  directly without a namespace, and that fails compilation for some compilers, like BlackBerry porting.

Need using namespace std to get through.
Comment 1 Charles Wei 2012-03-30 02:18:29 PDT 
Created attachment 134750 [details]
Patch

strcmp and memcmp are c library APIs and should be in std namespace.
Comment 2 Antonio Gomes 2012-04-03 20:37:39 PDT 
please adjust the new bug title in the changelog before landing...
Comment 3 Charles Wei 2012-04-04 18:14:28 PDT 
Created attachment 135736 [details]
Patch
Comment 4 Charles Wei 2012-04-04 18:18:33 PDT 
Comment on attachment 135736 [details]
Patch

Thanks for the review, Antonio.
Comment 5 WebKit Review Bot 2012-04-04 20:43:39 PDT 
Comment on attachment 135736 [details]
Patch

Clearing flags on attachment: 135736

Committed r113283: <http://trac.webkit.org/changeset/113283>
Comment 6 WebKit Review Bot 2012-04-04 20:43:43 PDT 
All reviewed patches have been landed.  Closing bug.