Bug 82699 – [Refactoring] Move Selection from DOMWindow to TreeScope

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Shinya Kawanaka]

Since ShadowRoot will also manage its own version of Selection, it would be beautiful if Selection is owned by TreeScope instead of DOMWindow.

[Shinya Kawanaka]

Created attachment 141088 [details]
WIP

[Early Warning System Bot]

Comment on attachment 141088 [details]
WIP

Attachment 141088 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12647828

[Early Warning System Bot]

Comment on attachment 141088 [details]
WIP

Attachment 141088 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12646889

[Build Bot]

Comment on attachment 141088 [details]
WIP

Attachment 141088 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12645954

[Gyuyoung Kim]

Comment on attachment 141088 [details]
WIP

Attachment 141088 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12666058

[Shinya Kawanaka]

Created attachment 141092 [details]
WIP

[Build Bot]

Comment on attachment 141092 [details]
WIP

Attachment 141092 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12644954

[Build Bot]

Comment on attachment 141092 [details]
WIP

Attachment 141092 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12649947

[Early Warning System Bot]

Comment on attachment 141092 [details]
WIP

Attachment 141092 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12666066

[Early Warning System Bot]

Comment on attachment 141092 [details]
WIP

Attachment 141092 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12653824

[Shinya Kawanaka]

Created attachment 141102 [details]
WIP

[Shinya Kawanaka]

Created attachment 141110 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 141110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141110&action=review

> Source/WebCore/dom/TreeScope.cpp:60
> +        m_selection->disconnectTreeScope();

I would call it clearTreeScope.

[Shinya Kawanaka]

(In reply to comment #13)
> (From update of attachment 141110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141110&action=review
> 
> > Source/WebCore/dom/TreeScope.cpp:60
> > +        m_selection->disconnectTreeScope();
> 
> I would call it clearTreeScope.

Thank you for very fast reviewing!
I'll update the patch.

[Shinya Kawanaka]

Created attachment 141309 [details]
Patch for landing

[Shinya Kawanaka]

Committed r116715: <http://trac.webkit.org/changeset/116715>

[WebKit Review Bot]

Re-opened since this is blocked by 86172

[Kent Tamura]

It seems that cross-frame-access-selection.html was broken by the patch.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-selection.html

[Shinya Kawanaka]

(In reply to comment #18)
> It seems that cross-frame-access-selection.html was broken by the patch.
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-selection.html

Thank you for notifying that!

I've investigated the issue. Making DOMSelection non-DOMWindowProperty seems to cause that issue. I'll update the patch soon. I think this patch should be reviewed again.

[Shinya Kawanaka]

Created attachment 141344 [details]
Patch

[WebKit Review Bot]

Comment on attachment 141344 [details]
Patch

Clearing flags on attachment: 141344

Committed r116746: <http://trac.webkit.org/changeset/116746>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.