Bug 82695 - [BlackBerry] Add local: protocol support in KURL for blackberry
Summary: [BlackBerry] Add local: protocol support in KURL for blackberry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-03-29 23:25 PDT by Leo Yang
Modified: 2012-04-04 21:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2012-03-29 23:29 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-29 23:25:33 PDT 
BlackBerry porting is using local: protocol just as file: protocol with the exception that it sandboxes the path to the application private space.
Comment 1 Leo Yang 2012-03-29 23:29:43 PDT 
Created attachment 134731 [details]
Patch
Comment 2 Rob Buis 2012-04-03 13:12:08 PDT 
Comment on attachment 134731 [details]
Patch

The code change looks ok. Please make sure we really use this code before cq+.
Comment 3 Leo Yang 2012-04-04 20:35:39 PDT 
(In reply to comment #2)
> (From update of attachment 134731 [details])
> The code change looks ok. Please make sure we really use this code before cq+.

Thanks for your review. We are using KURL::parse() for local:/// urls and we can reach the patched code chunk in KURL::parse(). I don't find a case to reach portAllowed() for both file:/// and local:///. But because there is checking of file:/// protocol in portAllowed(), we should add checking of local:/// since local:/// is same as file:/// here.
Comment 4 Leo Yang 2012-04-04 20:36:13 PDT 
Comment on attachment 134731 [details]
Patch

Sending to cq ...
Comment 5 WebKit Review Bot 2012-04-04 21:06:46 PDT 
Comment on attachment 134731 [details]
Patch

Clearing flags on attachment: 134731

Committed r113285: <http://trac.webkit.org/changeset/113285>
Comment 6 WebKit Review Bot 2012-04-04 21:06:51 PDT 
All reviewed patches have been landed.  Closing bug.