Bug 82667 - shape-inside and shape-outside are not in the list of computed style properties
Summary: shape-inside and shape-outside are not in the list of computed style properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 82363
  Show dependency tree / graph
 
Reported: 2012-03-29 15:13 PDT by Bear Travis
Modified: 2012-03-30 17:46 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch adding computed properties (18.30 KB, patch)
2012-03-30 10:23 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
updated patch (18.84 KB, patch)
2012-03-30 15:36 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-03-29 15:13:13 PDT 
The style declaration result of getComputedProperties does not contain -webkit-shape-inside and -webkit-shape-outside
These constants need to be added to CSSComputedStyleDeclaration::computedProperties

Split from 82365
Comment 1 Bear Travis 2012-03-30 10:23:19 PDT 
Created attachment 134836 [details]
proposed patch adding computed properties

Adding -webkit-shape-inside and -webkit-shape-outside to the list of computed properties returned by getComputedStyle.
Comment 2 Andreas Kling 2012-03-30 14:24:26 PDT 
Comment on attachment 134836 [details]
proposed patch adding computed properties

View in context: https://bugs.webkit.org/attachment.cgi?id=134836&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:318
> +    CSSPropertyWebkitShapeInside,
> +    CSSPropertyWebkitShapeOutside

Shouldn't this list be in alphabetical order?
Comment 3 Bear Travis 2012-03-30 15:36:31 PDT 
Created attachment 134901 [details]
updated patch

adding properties in alphabetical order
Comment 4 WebKit Review Bot 2012-03-30 17:46:22 PDT 
Comment on attachment 134901 [details]
updated patch

Clearing flags on attachment: 134901

Committed r112755: <http://trac.webkit.org/changeset/112755>
Comment 5 WebKit Review Bot 2012-03-30 17:46:26 PDT 
All reviewed patches have been landed.  Closing bug.