Bug 82659 - Scripts fail to detect when a tool crashes
Summary: Scripts fail to detect when a tool crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 14:33 PDT by Simon Fraser (smfr)
Modified: 2012-03-30 15:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2012-03-29 14:34 PDT, Simon Fraser (smfr)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-03-29 14:33:05 PDT
Bug 82652 describes a problem where TestWebKitAPI crashes, but the scripts fail to detect this crash.
Comment 1 Simon Fraser (smfr) 2012-03-29 14:34:35 PDT
Created attachment 134667 [details]
Patch
Comment 2 Mark Rowe (bdash) 2012-03-29 14:44:26 PDT
Comment on attachment 134667 [details]
Patch

Do we need to do something similar in the MSWin32 case above?
Comment 3 Simon Fraser (smfr) 2012-03-29 14:48:16 PDT
(In reply to comment #2)
> (From update of attachment 134667 [details])
> Do we need to do something similar in the MSWin32 case above?

Probably, but I wasn't able to easily find info on Windows exit codes. I'll keep this bug open for that.
Comment 4 Simon Fraser (smfr) 2012-03-29 14:49:11 PDT
http://trac.webkit.org/changeset/112580
Comment 5 Simon Fraser (smfr) 2012-03-30 15:31:38 PDT
Fixed in r112580 .