Bug 82649 - Simplify reporting a main resource error to DocumentLoader and FrameLoader.
Summary: Simplify reporting a main resource error to DocumentLoader and FrameLoader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 13:32 PDT by Nate Chapin
Modified: 2012-03-29 16:17 PDT (History)
3 users (show)

See Also:

Attachments
patch (7.79 KB, patch)
2012-03-29 13:36 PDT, Nate Chapin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2012-03-29 13:32:08 PDT 
There's a concept of a "complete" main resource error, which is obsolete, since all errors are complete.  Also, there's a call sequence of MainResourceLoader -> FrameLoader -> DocumentLoader -> FrameLoader -> DocumentLoader, which can definitely be simplified.
Comment 1 Nate Chapin 2012-03-29 13:36:50 PDT 
Created attachment 134657 [details]
patch
Comment 2 Adam Barth 2012-03-29 14:37:55 PDT 
I'm imagining reading this patch in reverse.  "Introduce a paramater that's always true..."
Comment 3 WebKit Review Bot 2012-03-29 16:17:29 PDT 
Comment on attachment 134657 [details]
patch

Clearing flags on attachment: 134657

Committed r112599: <http://trac.webkit.org/changeset/112599>
Comment 4 WebKit Review Bot 2012-03-29 16:17:34 PDT 
All reviewed patches have been landed.  Closing bug.