RESOLVED FIXED 82637
Template the Yarr::Interpreter on the character type 
https://bugs.webkit.org/show_bug.cgi?id=82637
Summary Template the Yarr::Interpreter on the character type
Gavin Barraclough
Reported 2012-03-29 12:10:09 PDT
We should be able to call to the interpreter after having already checked the character type, without having to re-package the character pointer back up into a string!
Attachments
Fix (13.26 KB, patch)
2012-03-29 12:13 PDT, Gavin Barraclough 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-03-29 12:13:00 PDT
Created attachment 134638 [details] Fix No performance impact
WebKit Review Bot
Comment 2 2012-03-29 12:18:05 PDT
Attachment 134638 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/yarr/YarrInterpreter.h:380: The parameter name "bytecode" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/yarr/YarrInterpreter.h:381: The parameter name "bytecode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-03-29 12:47:27 PDT
Comment on attachment 134638 [details] Fix Attachment 134638 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12204402
Sam Weinig
Comment 4 2012-03-29 13:05:46 PDT
Comment on attachment 134638 [details] Fix You are windows breaker!
Gavin Barraclough
Comment 5 2012-03-29 13:16:54 PDT
Fixed in r112564
Note You need to log in before you can comment on or make changes to this bug.