Bug 82625 - Web Inspector: improve window selection accuracy in vertical overview of timeline panel
Summary: Web Inspector: improve window selection accuracy in vertical overview of time...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 09:59 PDT by Andrey Kosyakov
Modified: 2012-03-29 11:35 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2012-03-29 10:01 PDT, Andrey Kosyakov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-03-29 09:59:26 PDT
This fixes a number of small errors when calculating window boundaries for vertical overview mode.
Comment 1 Andrey Kosyakov 2012-03-29 10:01:23 PDT
Created attachment 134608 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-29 11:19:00 PDT
Comment on attachment 134608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134608&action=review

> Source/WebCore/ChangeLog:7
> +

Please add: This fixes a number of small errors when calculating window boundaries for vertical overview mode.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:992
> +        this._actualBarWidth = Math.min((this.element.width - 2 * this._outerPadding) / allBarHeights.length, this._maxInnerBarWidth + maxPadding);

_actualOuterBarWidth
Comment 3 Andrey Kosyakov 2012-03-29 11:35:27 PDT
Committed r112554: <http://trac.webkit.org/changeset/112554>