WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82621
Web Inspector: check more likely condition first in HeapSnapshot._buildAggregates
https://bugs.webkit.org/show_bug.cgi?id=82621
Summary
Web Inspector: check more likely condition first in HeapSnapshot._buildAggreg...
Yury Semikhatsky
Reported
2012-03-29 09:06:41 PDT
Check more likely condition first in HeapSnapshot._buildAggregates.
Attachments
Patch
(5.24 KB, patch)
2012-03-29 09:10 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
Patch
(4.36 KB, patch)
2012-03-29 09:14 PDT
,
Yury Semikhatsky
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2012-03-29 09:10:46 PDT
Created
attachment 134597
[details]
Patch
Yury Semikhatsky
Comment 2
2012-03-29 09:12:54 PDT
(In reply to
comment #1
)
> Created an attachment (id=134597) [details] > Patch
Results of PerformanceTests/inspector/detailed-heapshots-smoke-test.html With the patch applied: RESULT heap-snapshot: _buildAggregates= 4565 ms RESULT heap-snapshot: switch-to-containment-view= 4901 ms Without the patch: RESULT heap-snapshot: _buildAggregates= 5593 ms RESULT heap-snapshot: switch-to-containment-view= 5838 ms
Yury Semikhatsky
Comment 3
2012-03-29 09:14:35 PDT
Created
attachment 134598
[details]
Patch
Pavel Feldman
Comment 4
2012-03-29 09:16:44 PDT
Comment on
attachment 134598
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=134598&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:1094 > + if (node.selfSize === 0 && !node.isNative)
We don't compare to 0 in WebKit, use !node.selfSize.
Yury Semikhatsky
Comment 5
2012-03-29 09:21:39 PDT
(In reply to
comment #4
)
> (From update of
attachment 134598
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=134598&action=review
> > > Source/WebCore/inspector/front-end/HeapSnapshot.js:1094 > > + if (node.selfSize === 0 && !node.isNative) > > We don't compare to 0 in WebKit, use !node.selfSize.
Done.
Yury Semikhatsky
Comment 6
2012-03-29 09:25:44 PDT
Committed
r112540
: <
http://trac.webkit.org/changeset/112540
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug