RESOLVED FIXED Bug 82606
Web Inspector: use canvas to render bars in "vertical overview" mode 
https://bugs.webkit.org/show_bug.cgi?id=82606
Summary Web Inspector: use canvas to render bars in "vertical overview" mode
Andrey Kosyakov
Reported 2012-03-29 06:17:23 PDT
This gives us better accuracy when mapping window selection to bars compared to flex boxes and slightly improves performance. This also gives us better control over spacing between bars.
Attachments
Patch (8.98 KB, patch)
2012-03-29 06:18 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (9.11 KB, patch)
2012-03-29 06:28 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-03-29 06:18:57 PDT
Created attachment 134561 [details] Patch
Pavel Feldman
Comment 2 2012-03-29 06:21:42 PDT
Comment on attachment 134561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review > Source/WebCore/ChangeLog:8 > + * inspector/front-end/TimelineOverviewPane.js: What and why did change? It sounds like you need to generate some text here even for trivial changes like this.
Andrey Kosyakov
Comment 3 2012-03-29 06:28:46 PDT
Created attachment 134563 [details] Patch
Andrey Kosyakov
Comment 4 2012-03-29 06:31:21 PDT
(In reply to comment #2) > (From update of attachment 134561 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review > > > Source/WebCore/ChangeLog:8 > > + * inspector/front-end/TimelineOverviewPane.js: > > What and why did change? It sounds like you need to generate some text here even for trivial changes like this. I added a couple of lines there. Please let me know if this is more comprehensible now or if you see a better summary for what was done.
Andrey Kosyakov
Comment 5 2012-03-29 06:48:02 PDT
Committed r112528: <http://trac.webkit.org/changeset/112528>
Note You need to log in before you can comment on or make changes to this bug.