Bug 82606 - Web Inspector: use canvas to render bars in "vertical overview" mode
Summary: Web Inspector: use canvas to render bars in "vertical overview" mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 06:17 PDT by Andrey Kosyakov
Modified: 2012-03-29 06:48 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.98 KB, patch)
2012-03-29 06:18 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (9.11 KB, patch)
2012-03-29 06:28 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-03-29 06:17:23 PDT 
This gives us better accuracy when mapping window selection to bars compared to flex boxes and slightly improves performance.
This also gives us better control over spacing between bars.
Comment 1 Andrey Kosyakov 2012-03-29 06:18:57 PDT 
Created attachment 134561 [details]
Patch
Comment 2 Pavel Feldman 2012-03-29 06:21:42 PDT 
Comment on attachment 134561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review

> Source/WebCore/ChangeLog:8
> +        * inspector/front-end/TimelineOverviewPane.js:

What and why did change? It sounds like you need to generate some text here even for trivial changes like this.
Comment 3 Andrey Kosyakov 2012-03-29 06:28:46 PDT 
Created attachment 134563 [details]
Patch
Comment 4 Andrey Kosyakov 2012-03-29 06:31:21 PDT 
(In reply to comment #2)
> (From update of attachment 134561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        * inspector/front-end/TimelineOverviewPane.js:
> 
> What and why did change? It sounds like you need to generate some text here even for trivial changes like this.

I added a couple of lines there. Please let me know if this is more comprehensible now or if you see a better summary for what was done.
Comment 5 Andrey Kosyakov 2012-03-29 06:48:02 PDT 
Committed r112528: <http://trac.webkit.org/changeset/112528>