Bug 82602 - Web Inspector: "go to the previous panel" shortcut is painful to maintain
Summary: Web Inspector: "go to the previous panel" shortcut is painful to maintain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 05:48 PDT by Pavel Feldman
Modified: 2012-03-29 11:00 PDT (History)
10 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2012-03-29 06:40 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2012-03-29 07:50 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2012-03-29 08:01 PDT, Pavel Feldman
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-03-29 05:48:01 PDT
Present go back shortcut "Cmd - Left" gets painful to support since we have more and more free flow editing capabilities (where Cmd - Left is handled by the editor). I'm suggesting that we remap it to Cmd - Option - Left (Ctrl - Alt - Left).
Comment 1 Pavel Feldman 2012-03-29 06:40:14 PDT
Created attachment 134567 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-29 07:49:25 PDT
Comment on attachment 134567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134567&action=review

> Source/WebCore/ChangeLog:10
> +        Remaping it to Cmd - Option - Left (Ctrl - Alt - Left).

Your ChangeLog is inconsistent with the code.
Comment 3 Pavel Feldman 2012-03-29 07:50:01 PDT
Created attachment 134583 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-29 07:57:51 PDT
Comment on attachment 134583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134583&action=review

> Source/WebCore/ChangeLog:10
> +        Remaping it to Cmd - Option - Left (Ctrl - Alt - [ (]) ).

This looks weird.
On the last line: Left -> [
Comment 5 Pavel Feldman 2012-03-29 08:01:37 PDT
Created attachment 134588 [details]
Patch
Comment 6 Early Warning System Bot 2012-03-29 08:43:32 PDT
Comment on attachment 134588 [details]
Patch

Attachment 134588 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12193370
Comment 7 Pavel Feldman 2012-03-29 09:22:38 PDT
Committed r112539: <http://trac.webkit.org/changeset/112539>
Comment 8 Vsevolod Vlasov 2012-03-29 11:00:48 PDT
Comment on attachment 134588 [details]
Patch

Clearing r?