RESOLVED FIXED 82597
[BlackBerry] Add Internal test support for blackberry porting.
https://bugs.webkit.org/show_bug.cgi?id=82597
Summary [BlackBerry] Add Internal test support for blackberry porting.
Charles Wei
Reported 2012-03-29 04:30:13 PDT
Need to add the internal testing IDLs for blackberry porting.
Attachments
Patch that enables Internal testing support for BlackBerry (1.73 KB, patch)
2012-03-29 04:35 PDT, Charles Wei
no flags
Patch V2 that fixes some typo in last patch. (1.73 KB, patch)
2012-03-29 04:57 PDT, Charles Wei
no flags
Charles Wei
Comment 1 2012-03-29 04:35:44 PDT
Created attachment 134546 [details] Patch that enables Internal testing support for BlackBerry
Rob Buis
Comment 2 2012-03-29 04:39:17 PDT
Comment on attachment 134546 [details] Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review > Source/WebCore/ChangeLog:8 > + No new tests, just the build system ehancement for BlackBerry porting. Typo ehancement :) > Source/WebCore/UseJSC.cmake:22 > +ENDIF () Is there anything in WebKit/blackberry cmake file that involves internal test support?
Charles Wei
Comment 3 2012-03-29 04:55:21 PDT
Comment on attachment 134546 [details] Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests, just the build system ehancement for BlackBerry porting. > > Typo ehancement :) Thanks, will fix it with next patch. >> Source/WebCore/UseJSC.cmake:22 >> +ENDIF () > > Is there anything in WebKit/blackberry cmake file that involves internal test support? I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ?
Charles Wei
Comment 4 2012-03-29 04:57:57 PDT
Created attachment 134550 [details] Patch V2 that fixes some typo in last patch.
Rob Buis
Comment 5 2012-03-29 05:05:53 PDT
Comment on attachment 134550 [details] Patch V2 that fixes some typo in last patch. Looks good.
Rob Buis
Comment 6 2012-03-29 05:07:51 PDT
(In reply to comment #3) > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. Cheers, Rob.
Charles Wei
Comment 7 2012-03-29 05:11:22 PDT
(In reply to comment #6) > (In reply to comment #3) > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > Cheers, > > Rob. Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any.
WebKit Review Bot
Comment 8 2012-03-29 05:45:54 PDT
Comment on attachment 134550 [details] Patch V2 that fixes some typo in last patch. Clearing flags on attachment: 134550 Committed r112525: <http://trac.webkit.org/changeset/112525>
WebKit Review Bot
Comment 9 2012-03-29 05:46:00 PDT
All reviewed patches have been landed. Closing bug.
Rob Buis
Comment 10 2012-03-29 06:56:15 PDT
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #3) > > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > > Cheers, > > > > Rob. > > Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any. My intuition was good :) We missed this in Source/WebKit/PlatformBlackBerry.cmake: "${WEBCORE_DIR}/testing/js" However we can do a bug fix to bring the whole file up to date later, I am sure there are more changes we need to sync.
Note You need to log in before you can comment on or make changes to this bug.