RESOLVED FIXED Bug 82591
[EFL] LayoutTestController needs implementation of isPageBoxVisible 
https://bugs.webkit.org/show_bug.cgi?id=82591
Summary [EFL] LayoutTestController needs implementation of isPageBoxVisible
Alexander Shalamov
Reported 2012-03-29 03:12:43 PDT
LayoutTestController needs implementation of isPageBoxVisible in order to unskip printing/page-format-data.html
Attachments
Patch (4.95 KB, patch)
2012-03-29 03:16 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Patch (5.34 KB, patch)
2012-03-30 00:12 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Shalamov
Comment 1 2012-03-29 03:16:59 PDT
Created attachment 134539 [details] Patch DRT support for isPageBoxVisible
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-03-29 13:10:40 PDT
Comment on attachment 134539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134539&action=review > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:124 > + WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame); Nitpick: could be const. > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:129 > + return frame->document()->isPageBoxVisible(pageIndex); Are you guaranteed to always have a valid Document?
Alexander Shalamov
Comment 3 2012-03-30 00:12:40 PDT
Created attachment 134736 [details] Patch Added fix according to the review comments Added description to the changelogs
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-03-30 12:52:28 PDT
If this one blocks bug 82589, shouldn't you ask for review for this one and remove the flags in the other bug?
Alexander Shalamov
Comment 5 2012-04-01 22:05:28 PDT
Comment on attachment 134736 [details] Patch Set review and commit-queue flags.
Gyuyoung Kim
Comment 6 2012-04-01 22:20:27 PDT
Comment on attachment 134736 [details] Patch Looks fine.
WebKit Review Bot
Comment 7 2012-04-02 22:06:00 PDT
Comment on attachment 134736 [details] Patch Clearing flags on attachment: 134736 Committed r112985: <http://trac.webkit.org/changeset/112985>
WebKit Review Bot
Comment 8 2012-04-02 22:06:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.