Bug 82591 - [EFL] LayoutTestController needs implementation of isPageBoxVisible
Summary: [EFL] LayoutTestController needs implementation of isPageBoxVisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Shalamov
URL:
Keywords:
Depends on:
Blocks: 82589
  Show dependency tree / graph
 
Reported: 2012-03-29 03:12 PDT by Alexander Shalamov
Modified: 2012-08-14 05:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.95 KB, patch)
2012-03-29 03:16 PDT, Alexander Shalamov 		no flags Details | Formatted Diff | Diff
Patch (5.34 KB, patch)
2012-03-30 00:12 PDT, Alexander Shalamov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Shalamov 2012-03-29 03:12:43 PDT 
LayoutTestController needs implementation of isPageBoxVisible in order to unskip printing/page-format-data.html
Comment 1 Alexander Shalamov 2012-03-29 03:16:59 PDT 
Created attachment 134539 [details]
Patch

DRT support for isPageBoxVisible
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-29 13:10:40 PDT 
Comment on attachment 134539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134539&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:124
> +    WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);

Nitpick: could be const.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:129
> +    return frame->document()->isPageBoxVisible(pageIndex);

Are you guaranteed to always have a valid Document?
Comment 3 Alexander Shalamov 2012-03-30 00:12:40 PDT 
Created attachment 134736 [details]
Patch

Added fix according to the review comments
Added description to the changelogs
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-30 12:52:28 PDT 
If this one blocks bug 82589, shouldn't you ask for review for this one and remove the flags in the other bug?
Comment 5 Alexander Shalamov 2012-04-01 22:05:28 PDT 
Comment on attachment 134736 [details]
Patch

Set review and commit-queue flags.
Comment 6 Gyuyoung Kim 2012-04-01 22:20:27 PDT 
Comment on attachment 134736 [details]
Patch

Looks fine.
Comment 7 WebKit Review Bot 2012-04-02 22:06:00 PDT 
Comment on attachment 134736 [details]
Patch

Clearing flags on attachment: 134736

Committed r112985: <http://trac.webkit.org/changeset/112985>
Comment 8 WebKit Review Bot 2012-04-02 22:06:05 PDT 
All reviewed patches have been landed.  Closing bug.