Followup to #81482, as stated in comment #5 on OpenBSD/NetBSD you need to include sys/param.h to use sysctl(), otherwise some #defines are missing. Is it a problem to also include it on darwin/freebsd, or should it be made for all 4 oses ?
Using sys/param.h should be fine on FreeBSD as well (it includes sys/types.h if LOCORE is not defined). Dunno about OS X, as I don't have access to a Mac. You could try sending a patch and checking if the bots complain.
Created attachment 138667 [details] Include sys/param.h to use sysctl() on Open/NetBSD Dunno if setting review to ? will be enough to trigger the bots...
You need to submit a patch against the top-level tree, it looks like you've diff'ed against Source/WTF.
Yeah, i don't have the full repo, only Source/. You guys have an insanely huge repo, i tried to svn co trunk once and gave up.
Created attachment 138760 [details] Include sys/param.h to use sysctl() on Open/NetBSD Lets retry
(In reply to comment #4) > Yeah, i don't have the full repo, only Source/. You guys have an insanely huge repo, i tried to svn co trunk once and gave up. The largest part of it is the LayoutTests/ directory, which you can ignore. $ svn co -N http://svn.webkit.org/repository/webkit/trunk WebKit $ cd WebKit $ svn up Source Additionally, the Tools/ directory has some useful scripts to help generate the ChangeLog entries and things like that.
All green on the bots.. anyone care to review/commit ?
Comment on attachment 138760 [details] Include sys/param.h to use sysctl() on Open/NetBSD r=me
Comment on attachment 138760 [details] Include sys/param.h to use sysctl() on Open/NetBSD Clearing flags on attachment: 138760 Committed r115254: <http://trac.webkit.org/changeset/115254>
All reviewed patches have been landed. Closing bug.