Bug 82580 – configure fails during gstreamer detection

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Landry Breuil]

Assigned to webkitgtk but that should be against 'build  system' ... webkitgtk 1.8.0 fails to pass configure on OpenBSD :

checking for GSTREAMER... no
configure: error: Package requirements (gstreamer-0.10 >= GSTREAMER_0_10_REQUIRED_VERSION
                     gstreamer-app-0.10
                     gstreamer-audio-0.10
                     gstreamer-fft-0.10
                     gstreamer-base-0.10
                     gstreamer-interfaces-0.10
                     gstreamer-pbutils-0.10
                     gstreamer-plugins-base-0.10 >= GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION
                     gstreamer-video-0.10) were not met:

Package >= was not found in the pkg-config search path
Package GSTREAMER_0_10_REQUIRED_VERSION was not found in the pkg-config search path
Package GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION was not found in the pkg-config search path

http://trac.webkit.org/changeset/106340 introduces a problem with variable assignation in configure :

+ case "$with_gstreamer" in
+-     0.10) GSTREAMER_REQUIRED_VERSION=GSTREAMER_0_10_REQUIRED_VERSION
+-           GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION
++     0.10) GSTREAMER_REQUIRED_VERSION=$GSTREAMER_0_10_REQUIRED_VERSION
++           GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=$GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION

That change fixes the issue for me. If it's confirmed and not yet fixed/dupe, i'll make a proper patch against configure.ac fixing the 0.11 codepath too.

[Philippe Normand]

Interesting, I wonder why the buildbots don't bother about this issue... Will send a patch, thanks for reporting!

[Philippe Normand]

Or feel free to send the patch, I'd be happy to review it :)

[Landry Breuil]

Created attachment 138659 [details]
Fix gstreamer configure detection

Here you are..

[WebKit Review Bot]

Comment on attachment 138659 [details]
Fix gstreamer configure detection

Clearing flags on attachment: 138659

Committed r115737: <http://trac.webkit.org/changeset/115737>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.