Bug 82578 - Pack bitfields in InlineBox for Windows
Summary: Pack bitfields in InlineBox for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 00:44 PDT by Ryosuke Niwa
Modified: 2012-03-29 14:08 PDT (History)
11 users (show)

See Also:

Attachments
Initial attempt (59.36 KB, patch)
2012-03-29 00:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-29 00:44:39 PDT 
Pack bitfields in InlineBox for Windows
Comment 1 Ryosuke Niwa 2012-03-29 00:55:24 PDT 
Created attachment 134519 [details]
Initial attempt
Comment 2 Kent Tamura 2012-03-29 02:07:20 PDT 
Comment on attachment 134519 [details]
Initial attempt

Looks good.
Comment 3 WebKit Review Bot 2012-03-29 02:49:01 PDT 
Comment on attachment 134519 [details]
Initial attempt

Clearing flags on attachment: 134519

Committed r112512: <http://trac.webkit.org/changeset/112512>
Comment 4 WebKit Review Bot 2012-03-29 02:49:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2012-03-29 12:20:32 PDT 
Sadly, this change appears to have had no effect on page cycler results:
http://build.chromium.org/p/chromium.webkit/builders/Vista%20Perf/builds/9443
Comment 6 Eric Seidel (no email) 2012-03-29 12:39:12 PDT 
Do we know from COMPILE_ASSERTS that we definitely made these smaller on Win?
Comment 7 Ryosuke Niwa 2012-03-29 13:54:21 PDT 
(In reply to comment #6)
> Do we know from COMPILE_ASSERTS that we definitely made these smaller on Win?

Yes. The InlineBox's size was reduced from 40 bytes to 36 bytes. So that's about 10% reduction in its size. Maybe the size of InlineBox doesn't matter as much. It's possible that we're over-optimzing in this area.
Comment 8 Ryosuke Niwa 2012-03-29 14:08:58 PDT 
Of course, it might also mean that we don't have good tests.