Bug 82574 - [BlackBerry] Add m_targetType to WorkerScriptLoader
Summary: [BlackBerry] Add m_targetType to WorkerScriptLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-03-28 23:30 PDT by Leo Yang
Modified: 2012-03-29 05:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2012-03-28 23:32 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-28 23:30:43 PDT 
Just as Chromium porting BlackBerry porting is using m_targetType also.
Comment 1 Leo Yang 2012-03-28 23:32:45 PDT 
Created attachment 134508 [details]
Patch
Comment 2 Charles Wei 2012-03-29 00:30:14 PDT 
Comment on attachment 134508 [details]
Patch

How did it pass the compile before this patch for BB porting?
Comment 3 Leo Yang 2012-03-29 00:49:26 PDT 
(In reply to comment #2)
> (From update of attachment 134508 [details])
> How did it pass the compile before this patch for BB porting?

What do you mean "before this patch"?
Comment 4 Leo Yang 2012-03-29 01:10:23 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 134508 [details] [details])
> > How did it pass the compile before this patch for BB porting?
> 
> What do you mean "before this patch"?

If you mean "How did it pass the compile without this patch for BB porting?", the answer is that for internal build the change has been there; for upstreaming build we definitely can't pass compile because there are lots of things to be upstreamed.
Comment 5 Rob Buis 2012-03-29 04:16:50 PDT 
Comment on attachment 134508 [details]
Patch

Ok.
Comment 6 WebKit Review Bot 2012-03-29 05:32:06 PDT 
Comment on attachment 134508 [details]
Patch

Clearing flags on attachment: 134508

Committed r112521: <http://trac.webkit.org/changeset/112521>
Comment 7 WebKit Review Bot 2012-03-29 05:32:14 PDT 
All reviewed patches have been landed.  Closing bug.