Bug 82573 - [BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
Summary: [BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-03-28 22:34 PDT by Leo Yang
Modified: 2012-03-29 20:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2012-03-28 22:38 PDT, Leo Yang 		rwlbuis: review+
Details | Formatted Diff | Diff
Patch for landing (1.80 KB, patch)
2012-03-29 18:43 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-28 22:34:38 PDT 
Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp for blackberry porting.
Comment 1 Leo Yang 2012-03-28 22:38:42 PDT 
Created attachment 134501 [details]
Patch
Comment 2 Rob Buis 2012-03-29 06:53:17 PDT 
Comment on attachment 134501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review

Looks good.

> Source/WebCore/ChangeLog:7
> +

You should mention here that it is covered by existing tests.
Comment 3 Leo Yang 2012-03-29 18:43:05 PDT 
Created attachment 134709 [details]
Patch for landing
Comment 4 Leo Yang 2012-03-29 18:44:41 PDT 
(In reply to comment #2)
> (From update of attachment 134501 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review
> 
> Looks good.
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> You should mention here that it is covered by existing tests.

I added this in the revised patch. Thanks for your review.
Comment 5 WebKit Review Bot 2012-03-29 20:04:41 PDT 
Comment on attachment 134709 [details]
Patch for landing

Clearing flags on attachment: 134709

Committed r112640: <http://trac.webkit.org/changeset/112640>
Comment 6 WebKit Review Bot 2012-03-29 20:04:46 PDT 
All reviewed patches have been landed.  Closing bug.