Bug 82567 – [BlackBerry] Sync up PlatformMouseEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Leo Yang]

This is to upstream the blackberry specific changes to PlatformMouseEvent.h and sync up the blackberry specific PlatformMouseEventBlackBerry.

[Leo Yang]

Created attachment 134490 [details]
Patch

[Rob Buis]

Comment on attachment 134490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review

> Source/WebCore/platform/PlatformMouseEvent.h:60
> +    enum MouseInputMethod { PointingDevice, TouchScreen };

Don't we have TouchEvent for TouchScreen?

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 134490 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review
> 
> > Source/WebCore/platform/PlatformMouseEvent.h:60
> > +    enum MouseInputMethod { PointingDevice, TouchScreen };
> 
> Don't we have TouchEvent for TouchScreen?

For single touch events (touch point press/release, etc), we convert them to PlatformMouse events and send them to WebCore. This is reasonable since single touch is very like mouse click.

[Rob Buis]

Comment on attachment 134490 [details]
Patch

Looks good.

[Leo Yang]

(In reply to comment #4)
> (From update of attachment 134490 [details])
> Looks good.

Thanks for your review.

[WebKit Review Bot]

Comment on attachment 134490 [details]
Patch

Clearing flags on attachment: 134490

Committed r112641: <http://trac.webkit.org/changeset/112641>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.