WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82567
[BlackBerry] Sync up PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=82567
Summary
[BlackBerry] Sync up PlatformMouseEvent
Leo Yang
Reported
2012-03-28 20:35:48 PDT
This is to upstream the blackberry specific changes to PlatformMouseEvent.h and sync up the blackberry specific PlatformMouseEventBlackBerry.
Attachments
Patch
(4.82 KB, patch)
2012-03-28 21:05 PDT
,
Leo Yang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Leo Yang
Comment 1
2012-03-28 21:05:16 PDT
Created
attachment 134490
[details]
Patch
Rob Buis
Comment 2
2012-03-29 04:13:05 PDT
Comment on
attachment 134490
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=134490&action=review
> Source/WebCore/platform/PlatformMouseEvent.h:60 > + enum MouseInputMethod { PointingDevice, TouchScreen };
Don't we have TouchEvent for TouchScreen?
Leo Yang
Comment 3
2012-03-29 19:10:21 PDT
(In reply to
comment #2
)
> (From update of
attachment 134490
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=134490&action=review
> > > Source/WebCore/platform/PlatformMouseEvent.h:60 > > + enum MouseInputMethod { PointingDevice, TouchScreen }; > > Don't we have TouchEvent for TouchScreen?
For single touch events (touch point press/release, etc), we convert them to PlatformMouse events and send them to WebCore. This is reasonable since single touch is very like mouse click.
Rob Buis
Comment 4
2012-03-29 19:29:25 PDT
Comment on
attachment 134490
[details]
Patch Looks good.
Leo Yang
Comment 5
2012-03-29 19:32:55 PDT
(In reply to
comment #4
)
> (From update of
attachment 134490
[details]
) > Looks good.
Thanks for your review.
WebKit Review Bot
Comment 6
2012-03-29 20:32:03 PDT
Comment on
attachment 134490
[details]
Patch Clearing flags on attachment: 134490 Committed
r112641
: <
http://trac.webkit.org/changeset/112641
>
WebKit Review Bot
Comment 7
2012-03-29 20:32:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug