Bug 82559 - Fix a crash and an assertion when recovering from a web process crash
Summary: Fix a crash and an assertion when recovering from a web process crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 18:07 PDT by Anders Carlsson
Modified: 2012-03-28 18:51 PDT (History)
0 users

See Also:

Attachments
Patch (1.87 KB, patch)
2012-03-28 18:08 PDT, Anders Carlsson 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-28 18:07:44 PDT 
Fix a crash and an assertion when recovering from a web process crash
Comment 1 Anders Carlsson 2012-03-28 18:08:49 PDT 
Created attachment 134459 [details]
Patch
Comment 2 Mark Rowe (bdash) 2012-03-28 18:10:13 PDT 
Comment on attachment 134459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134459&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2932
> +    if (_data->_page->drawingArea())
> +        _data->_page->drawingArea()->waitForPossibleGeometryUpdate();

Maybe introduce a local to avoid dereferencing / calling _data->_page->drawingArea() twice in a row?
Comment 3 Anders Carlsson 2012-03-28 18:51:03 PDT 
Committed r112491: <http://trac.webkit.org/changeset/112491>