WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 82556
Remove ScriptExecutionContext from NavigatorBattery.idl
https://bugs.webkit.org/show_bug.cgi?id=82556
Summary
Remove ScriptExecutionContext from NavigatorBattery.idl
Gyuyoung Kim
Reported
2012-03-28 18:04:13 PDT
As
Bug 73528 comment #71
, NavigatorBattery.idl doesn't need to have ScriptExecutionContext. Document can be used instead of ScriptExecutionContext.
Attachments
Patch
(5.85 KB, patch)
2012-03-28 18:05 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch
(5.86 KB, patch)
2012-03-28 18:52 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2012-03-28 18:05:48 PDT
Created
attachment 134456
[details]
Patch
Adam Barth
Comment 2
2012-03-28 18:11:30 PDT
Comment on
attachment 134456
[details]
Patch One argument constructors should have the "explicit" keyword.
Gyuyoung Kim
Comment 3
2012-03-28 18:52:20 PDT
Created
attachment 134470
[details]
Patch
Gyuyoung Kim
Comment 4
2012-03-28 18:53:31 PDT
Comment on
attachment 134470
[details]
Patch I add explicit keyword to construct. Thank you for your review.
WebKit Review Bot
Comment 5
2012-03-28 19:57:23 PDT
Comment on
attachment 134470
[details]
Patch Clearing flags on attachment: 134470 Committed
r112495
: <
http://trac.webkit.org/changeset/112495
>
WebKit Review Bot
Comment 6
2012-03-28 19:57:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug