Bug 82553 – [Chromium] Move APIs related to ResourceHandle into Platform

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] Move APIs related to ResourceHandle into Platform

[Adam Barth]

Created attachment 134452 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 134452 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/Platform/chromium/public/WebURL.h:136:  One space before end of line comments  [whitespace/comments] [5]
Source/Platform/chromium/public/WebPrivateOwnPtr.h:33:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebPrivateOwnPtr.h:42:  Missing space inside { }.  [whitespace/braces] [5]
Source/Platform/chromium/public/WebURLLoader.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/Platform/chromium/public/WebURLLoader.h:50:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebURLLoader.h:53:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/Platform/chromium/public/WebURLLoader.h:56:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebURLLoader.h:61:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebData.h:45:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/Platform/chromium/public/WebData.h:76:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 10 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

This patch just moves existing code.  I can address these style nits in a followup patch if you like.

[James Robinson]

Comment on attachment 134452 [details]
Patch

R=me. Do you know if there's a way to land this that ensures the svn metadata is set up as a move?

[Adam Barth]

> R=me. Do you know if there's a way to land this that ensures the svn metadata is set up as a move?

Landing via the commit-queue should take care of that, but I can land it manually via svn to make sure.

[Adam Barth]

Comment on attachment 134452 [details]
Patch

I'm going to give mjs sometime to comment before landing this patch in case he has thoughts.

[Adam Barth]

Committed r112501: <http://trac.webkit.org/changeset/112501>