Bug 82552 - run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed
Summary: run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, MakingBotsRed
Depends on: 82961
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-28 16:55 PDT by Stephanie Lewis
Modified: 2012-04-02 16:10 PDT (History)
6 users (show)

See Also:


Attachments
patch (1.55 KB, patch)
2012-03-28 16:59 PDT, Stephanie Lewis
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2012-03-28 16:55:28 PDT
run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.

The fix is to set DYLD_LIBRARY_PATH in addition to DYLD_FRAMEWORK_PATH
Comment 1 Radar WebKit Bug Importer 2012-03-28 16:56:16 PDT
<rdar://problem/11143199>
Comment 2 Stephanie Lewis 2012-03-28 16:59:10 PDT
Created attachment 134448 [details]
patch

uploaded patch.
Comment 3 Ryosuke Niwa 2012-03-28 17:07:59 PDT
Comment on attachment 134448 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134448&action=review

> Tools/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the description (but after bug title & bug url).

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:484
> +        environment['DYLD_LIBRARY_PATH'] = self._port._build_path()

There's no way to test this?
Comment 4 Adam Barth 2012-03-28 17:14:26 PDT
Comment on attachment 134448 [details]
patch

Eric would know.  I thought we had a unit test for these environment overrides.
Comment 5 Dirk Pranke 2012-03-30 20:25:29 PDT
Comment on attachment 134448 [details]
patch

I don't think this is worth testing ... The changelog should be fixed, though.
Comment 6 Dirk Pranke 2012-03-30 20:27:41 PDT
You could test this w/ MockExecutive and then look at the env that is passed to it, it's not going to tell you much. I suppose you could assert that it was at least set to something, but I wouldn't bother.
Comment 7 Stephanie Lewis 2012-04-02 15:08:11 PDT
Committed http://trac.webkit.org/projects/webkit/changeset/112948
Comment 8 Mark Rowe (bdash) 2012-04-02 15:53:33 PDT
Take a look at the diff at <http://trac.webkit.org/changeset/112948/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py>. And then please roll out this change.
Comment 9 Stephanie Lewis 2012-04-02 16:10:29 PDT
rolled out my change in http://trac.webkit.org/changeset/112958.  Simon committed the same thing here: http://trac.webkit.org/changeset/112739