run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed. The fix is to set DYLD_LIBRARY_PATH in addition to DYLD_FRAMEWORK_PATH
<rdar://problem/11143199>
Created attachment 134448 [details] patch uploaded patch.
Comment on attachment 134448 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=134448&action=review > Tools/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). This line should appear before the description (but after bug title & bug url). > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:484 > + environment['DYLD_LIBRARY_PATH'] = self._port._build_path() There's no way to test this?
Comment on attachment 134448 [details] patch Eric would know. I thought we had a unit test for these environment overrides.
Comment on attachment 134448 [details] patch I don't think this is worth testing ... The changelog should be fixed, though.
You could test this w/ MockExecutive and then look at the env that is passed to it, it's not going to tell you much. I suppose you could assert that it was at least set to something, but I wouldn't bother.
Committed http://trac.webkit.org/projects/webkit/changeset/112948
Take a look at the diff at <http://trac.webkit.org/changeset/112948/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py>. And then please roll out this change.
rolled out my change in http://trac.webkit.org/changeset/112958. Simon committed the same thing here: http://trac.webkit.org/changeset/112739