Bug 82549 – Change WebKit/WebKit2 platform code to use pixel snapped values

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Emil A Eklund]

Change WebKit and WebKit2 platform code to use rounded locations and pixel snapped rects and sizes. This avoids having to expose the fractional layout types to the platform code.

[Emil A Eklund]

Created attachment 134444 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 134444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134444&action=review

> Source/WebCore/dom/Node.h:380
>      LayoutRect renderRect(bool* isReplaced);
> +    IntRect pixelSnappedRenderRect(bool* isReplaced) { return pixelSnappedIntRect(renderRect(isReplaced)); }

Wouldn't this be easier to call renderRect().pixelSnapped() in the caller instead?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 134444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134444&action=review
> 
> > Source/WebCore/dom/Node.h:380
> >      LayoutRect renderRect(bool* isReplaced);
> > +    IntRect pixelSnappedRenderRect(bool* isReplaced) { return pixelSnappedIntRect(renderRect(isReplaced)); }
> 
> Wouldn't this be easier to call renderRect().pixelSnapped() in the caller instead?

It would but that would break the encapsulation and expose LayoutRects to the WebKit platform code, something we have been trying to avoid.

[Emil A Eklund]

Ping?

[Eric Seidel (no email)]

Comment on attachment 134444 [details]
Patch

Thank you for the ping.

[Emil A Eklund]

Comment on attachment 134444 [details]
Patch

Thanks for the review!

[WebKit Review Bot]

Comment on attachment 134444 [details]
Patch

Clearing flags on attachment: 134444

Committed r112758: <http://trac.webkit.org/changeset/112758>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.