RESOLVED FIXED 82539
Delete dispatchDidLoadMainResource callback 
https://bugs.webkit.org/show_bug.cgi?id=82539
Summary Delete dispatchDidLoadMainResource callback
Nate Chapin
Reported 2012-03-28 15:16:53 PDT
No port implements it, let's get rid of it.
Attachments
patch (23.13 KB, patch)
2012-03-28 15:26 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2012-03-28 15:26:32 PDT
Created attachment 134423 [details] patch
Alexey Proskuryakov
Comment 2 2012-03-28 15:49:03 PDT
Comment on attachment 134423 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=134423&action=review > Source/WebKit/mac/WebKit.order:-772 > -__ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE It's OK to modify this file, but no need to do that.
Nate Chapin
Comment 3 2012-03-28 15:54:09 PDT
(In reply to comment #2) > (From update of attachment 134423 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134423&action=review > > > Source/WebKit/mac/WebKit.order:-772 > > -__ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE > > It's OK to modify this file, but no need to do that. I'll keep that in mind for the future. I just deleted every occurence of "dispatchDidLoadMainResource" that wasn't in a ChangeLog :)
WebKit Review Bot
Comment 4 2012-03-28 16:58:40 PDT
Comment on attachment 134423 [details] patch Rejecting attachment 134423 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: reSupport/WebFrameLoaderClient.h.rej patching file Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Hunk #1 FAILED at 753. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp.rej patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Alexey Pro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12194002
WebKit Review Bot
Comment 5 2012-03-28 17:02:04 PDT
Comment on attachment 134423 [details] patch Clearing flags on attachment: 134423 Committed r112474: <http://trac.webkit.org/changeset/112474>
WebKit Review Bot
Comment 6 2012-03-28 17:02:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.