Bug 82535 - Change FilterOperations::getOutsets to use integers
Summary: Change FilterOperations::getOutsets to use integers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318 83041
  Show dependency tree / graph
 
Reported: 2012-03-28 15:04 PDT by Emil A Eklund
Modified: 2012-04-03 10:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.39 KB, patch)
2012-03-28 15:08 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-03-28 15:04:05 PDT 
FilterOperations::getOutsets calculates the outset based on integers and then upcasts the values to LayoutUnits.
Comment 1 Emil A Eklund 2012-03-28 15:08:38 PDT 
Created attachment 134413 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-28 15:47:07 PDT 
Comment on attachment 134413 [details]
Patch

Ha!  Yes, these make no sense as LayoutUnits. :)
Comment 3 Dirk Schulze 2012-03-28 15:51:30 PDT 
wouldn't it be easier to replace the 4 ints by one IntRect?
Comment 4 Emil A Eklund 2012-03-28 15:56:05 PDT 
(In reply to comment #3)
> wouldn't it be easier to replace the 4 ints by one IntRect?

Would be easier but as the numbers don't really represent a rectangle it would be a bit confusing. Perhaps we need some new data type for things like borders, outsets, margins and paddings where you have a value for each edge.
Comment 5 WebKit Review Bot 2012-03-28 16:57:32 PDT 
Comment on attachment 134413 [details]
Patch

Clearing flags on attachment: 134413

Committed r112475: <http://trac.webkit.org/changeset/112475>
Comment 6 WebKit Review Bot 2012-03-28 16:57:36 PDT 
All reviewed patches have been landed.  Closing bug.