[Qt][WK2] Sync the layer's state and the layer's children separately
Created attachment 134412 [details] Patch
Created attachment 134419 [details] Patch
Comment on attachment 134419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134419&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:431 > +void WebGraphicsLayer::syncImageBackingStore() sync isn't quite right, check? recreate? ensure? > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:435 > + if (!m_image) > + return; > + if (!m_layerInfo.imageBackingStoreID) if (m_image && !m_layerInfo.imageBackingStoreID) ? Otherwise, LGTM!
Comment on attachment 134419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134419&action=review > Source/WebKit2/ChangeLog:11 > + We also don't serialize the name, and serialize the children in a separate > + function, and only when the children have actually changed. This is hard to understand > Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:180 > + LayerMap::iterator it = m_layers.find(id); ASSERT it != notFound? >> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:431 >> +void WebGraphicsLayer::syncImageBackingStore() > > sync isn't quite right, check? recreate? ensure? ensure sounds fine
Created attachment 136260 [details] Patch
Comment on attachment 136260 [details] Patch This looks a lot simpler/cleaner.
Created attachment 136267 [details] Patch for landing
Comment on attachment 136267 [details] Patch for landing Rejecting attachment 136267 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: cceeded at 105 with fuzz 1 (offset 3 lines). Hunk #3 succeeded at 134 (offset 4 lines). Hunk #4 FAILED at 141. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h.rej patching file Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp patching file Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12372383
Comment on attachment 136267 [details] Patch for landing Clearing flags on attachment: 136267 Committed r113640: <http://trac.webkit.org/changeset/113640>
All reviewed patches have been landed. Closing bug.