Bug 82534 - [Qt][WK2] Sync the layer's state and the layer's children separately
Summary: [Qt][WK2] Sync the layer's state and the layer's children separately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks: 75780
  Show dependency tree / graph
 
Reported: 2012-03-28 14:57 PDT by Noam Rosenthal
Modified: 2012-04-09 16:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.08 KB, patch)
2012-03-28 15:08 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (27.83 KB, patch)
2012-03-28 15:13 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (27.95 KB, patch)
2012-04-09 10:24 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch for landing (27.96 KB, patch)
2012-04-09 10:54 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-03-28 14:57:17 PDT 
[Qt][WK2] Sync the layer's state and the layer's children separately
Comment 1 Noam Rosenthal 2012-03-28 15:08:19 PDT 
Created attachment 134412 [details]
Patch
Comment 2 Noam Rosenthal 2012-03-28 15:13:46 PDT 
Created attachment 134419 [details]
Patch
Comment 3 Jocelyn Turcotte 2012-03-29 05:06:53 PDT 
Comment on attachment 134419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134419&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:431
> +void WebGraphicsLayer::syncImageBackingStore()

sync isn't quite right, check? recreate? ensure?

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:435
> +    if (!m_image)
> +        return;
> +    if (!m_layerInfo.imageBackingStoreID)

if (m_image && !m_layerInfo.imageBackingStoreID) ?

Otherwise, LGTM!
Comment 4 Kenneth Rohde Christiansen 2012-04-03 07:24:52 PDT 
Comment on attachment 134419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134419&action=review

> Source/WebKit2/ChangeLog:11
> +        We also don't serialize the name, and serialize the children in a separate
> +        function, and only when the children have actually changed.

This is hard to understand

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:180
> +    LayerMap::iterator it = m_layers.find(id);

ASSERT it != notFound?

>> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:431
>> +void WebGraphicsLayer::syncImageBackingStore()
> 
> sync isn't quite right, check? recreate? ensure?

ensure sounds fine
Comment 5 Noam Rosenthal 2012-04-09 10:24:22 PDT 
Created attachment 136260 [details]
Patch
Comment 6 Kenneth Rohde Christiansen 2012-04-09 10:48:02 PDT 
Comment on attachment 136260 [details]
Patch

This looks a lot simpler/cleaner.
Comment 7 Noam Rosenthal 2012-04-09 10:54:51 PDT 
Created attachment 136267 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-04-09 14:35:28 PDT 
Comment on attachment 136267 [details]
Patch for landing

Rejecting attachment 136267 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
cceeded at 105 with fuzz 1 (offset 3 lines).
Hunk #3 succeeded at 134 (offset 4 lines).
Hunk #4 FAILED at 141.
1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h.rej
patching file Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp
patching file Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12372383
Comment 9 WebKit Review Bot 2012-04-09 16:45:59 PDT 
Comment on attachment 136267 [details]
Patch for landing

Clearing flags on attachment: 136267

Committed r113640: <http://trac.webkit.org/changeset/113640>
Comment 10 WebKit Review Bot 2012-04-09 16:46:06 PDT 
All reviewed patches have been landed.  Closing bug.