Bug 82525 - [Qt][WK2] Direct composited image assignment doesn't work
Summary: [Qt][WK2] Direct composited image assignment doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks: 75780
  Show dependency treegraph
 
Reported: 2012-03-28 14:04 PDT by Noam Rosenthal
Modified: 2012-03-29 17:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.74 KB, patch)
2012-03-28 15:11 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (4.32 KB, patch)
2012-03-29 15:01 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (4.87 KB, patch)
2012-03-29 15:16 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-03-28 14:04:36 PDT
[Qt][WK2] Direct composited image assignment doesn't work
Comment 1 Noam Rosenthal 2012-03-28 15:11:14 PDT
Created attachment 134416 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-03-29 05:07:03 PDT
Comment on attachment 134416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134416&action=review

LGTM, just one thing.

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:-176
> -    bool needsToUpdateImageTiles = layerInfo.imageIsUpdated || (layerInfo.contentsRect != layer->contentsRect() && layerInfo.imageBackingStoreID);

Please remove imageIsUpdated from WebLayerInfo::flags
Comment 3 Noam Rosenthal 2012-03-29 15:01:40 PDT
Created attachment 134674 [details]
Patch for landing
Comment 4 Noam Rosenthal 2012-03-29 15:16:08 PDT
Created attachment 134680 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-03-29 17:21:18 PDT
Comment on attachment 134680 [details]
Patch for landing

Clearing flags on attachment: 134680

Committed r112617: <http://trac.webkit.org/changeset/112617>
Comment 6 WebKit Review Bot 2012-03-29 17:21:23 PDT
All reviewed patches have been landed.  Closing bug.