Bug 82524 - [CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed
Summary: [CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
Keywords: InRadar
Depends on:
Reported: 2012-03-28 14:01 PDT by Alexandru Chiculita
Modified: 2012-03-28 20:43 PDT (History)
3 users (show)

See Also:

Patch V1 (2.74 KB, patch)
2012-03-28 15:25 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-03-28 14:01:13 PDT
RenderLayer::updateOrRemoveFilterEffect is called in clearBacking(), which is called from RenderLayer::~RenderLayer, meaning that the filters are rebuild when deleting a layer, but they are not going to be used anyway.

Avoid creating new filters when the RenderLayer is going out of scope.
Comment 1 Radar WebKit Bug Importer 2012-03-28 14:44:40 PDT
Comment 2 Alexandru Chiculita 2012-03-28 15:25:19 PDT
Created attachment 134422 [details]
Patch V1
Comment 3 WebKit Review Bot 2012-03-28 20:43:06 PDT
Comment on attachment 134422 [details]
Patch V1

Clearing flags on attachment: 134422

Committed r112497: <http://trac.webkit.org/changeset/112497>
Comment 4 WebKit Review Bot 2012-03-28 20:43:10 PDT
All reviewed patches have been landed.  Closing bug.