Bug 82523 – [Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Noam Rosenthal]

[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine

[Noam Rosenthal]

Created attachment 134410 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 134410 [details]
Patch

LGTM

[Kenneth Rohde Christiansen]

Comment on attachment 134410 [details]
Patch

Can this be tested?

[Noam Rosenthal]

(In reply to comment #3)
> (From update of attachment 134410 [details])
> Can this be tested?
It's already tested. The compositing tests with huge transformed layers test this.

[Kenneth Rohde Christiansen]

Comment on attachment 134410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review

> Source/WebKit2/ChangeLog:8
> +        Always use contentsScale of 1 and a full visibleContentsRect when

I hate the name for visibleContentsRect when it is more than that, especially if people use it differently

[Noam Rosenthal]

(In reply to comment #5)
> (From update of attachment 134410 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Always use contentsScale of 1 and a full visibleContentsRect when
> 
> I hate the name for visibleContentsRect when it is more than that, especially if people use it differently
It should probably be "visibleRectInContentsCoordinates". Though that's an issue for another patch...

[Noam Rosenthal]

Any other issues with this patch?

[Noam Rosenthal]

Created attachment 136254 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136254 [details]
Patch for landing

Clearing flags on attachment: 136254

Committed r113608: <http://trac.webkit.org/changeset/113608>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.