Bug 82523 - [Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
Summary: [Qt][WK2] Disable the content-scaling and visible contents rect when the laye...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks: 75780
  Show dependency treegraph
 
Reported: 2012-03-28 13:58 PDT by Noam Rosenthal
Modified: 2012-04-09 13:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.67 KB, patch)
2012-03-28 15:06 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (5.67 KB, patch)
2012-04-09 10:13 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-03-28 13:58:10 PDT
[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
Comment 1 Noam Rosenthal 2012-03-28 15:06:41 PDT
Created attachment 134410 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-03-29 05:07:06 PDT
Comment on attachment 134410 [details]
Patch

LGTM
Comment 3 Kenneth Rohde Christiansen 2012-03-29 05:14:13 PDT
Comment on attachment 134410 [details]
Patch

Can this be tested?
Comment 4 Noam Rosenthal 2012-03-29 06:47:38 PDT
(In reply to comment #3)
> (From update of attachment 134410 [details])
> Can this be tested?
It's already tested. The compositing tests with huge transformed layers test this.
Comment 5 Kenneth Rohde Christiansen 2012-04-03 07:13:19 PDT
Comment on attachment 134410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review

> Source/WebKit2/ChangeLog:8
> +        Always use contentsScale of 1 and a full visibleContentsRect when

I hate the name for visibleContentsRect when it is more than that, especially if people use it differently
Comment 6 Noam Rosenthal 2012-04-03 07:23:22 PDT
(In reply to comment #5)
> (From update of attachment 134410 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Always use contentsScale of 1 and a full visibleContentsRect when
> 
> I hate the name for visibleContentsRect when it is more than that, especially if people use it differently
It should probably be "visibleRectInContentsCoordinates". Though that's an issue for another patch...
Comment 7 Noam Rosenthal 2012-04-09 09:39:08 PDT
Any other issues with this patch?
Comment 8 Noam Rosenthal 2012-04-09 10:13:28 PDT
Created attachment 136254 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-04-09 13:01:42 PDT
Comment on attachment 136254 [details]
Patch for landing

Clearing flags on attachment: 136254

Committed r113608: <http://trac.webkit.org/changeset/113608>
Comment 10 WebKit Review Bot 2012-04-09 13:01:47 PDT
All reviewed patches have been landed.  Closing bug.