Bug 82522 - [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
Summary: [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks: 75780
  Show dependency treegraph
 
Reported: 2012-03-28 13:55 PDT by Noam Rosenthal
Modified: 2012-04-09 13:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.52 KB, patch)
2012-03-28 15:11 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (11.01 KB, patch)
2012-04-09 10:15 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-03-28 13:55:24 PDT
[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
Comment 1 Noam Rosenthal 2012-03-28 15:11:45 PDT
Created attachment 134417 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-03-29 05:07:09 PDT
Comment on attachment 134417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review

LGTM beside one nitpick.

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:73
> +    if (!transform().isAffine())

I guess this relates to shouldUseTiledBackingStore? Could you add a comment why it helps?
Comment 3 Kenneth Rohde Christiansen 2012-04-03 07:11:02 PDT
Comment on attachment 134417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:78
> +        toWebGraphicsLayer(children()[i])->setShouldUpdateVisibleRect();

hasPendingVisibleRectChange?

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:439
> +    if (!m_modified)
> +        return;

I would add a newline after each return statement
Comment 4 Noam Rosenthal 2012-04-09 10:15:57 PDT
Created attachment 136257 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-09 13:57:27 PDT
Comment on attachment 136257 [details]
Patch for landing

Clearing flags on attachment: 136257

Committed r113615: <http://trac.webkit.org/changeset/113615>
Comment 6 WebKit Review Bot 2012-04-09 13:57:33 PDT
All reviewed patches have been landed.  Closing bug.