Bug 82522 – [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Noam Rosenthal]

[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed

[Noam Rosenthal]

Created attachment 134417 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 134417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review

LGTM beside one nitpick.

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:73
> +    if (!transform().isAffine())

I guess this relates to shouldUseTiledBackingStore? Could you add a comment why it helps?

[Kenneth Rohde Christiansen]

Comment on attachment 134417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:78
> +        toWebGraphicsLayer(children()[i])->setShouldUpdateVisibleRect();

hasPendingVisibleRectChange?

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:439
> +    if (!m_modified)
> +        return;

I would add a newline after each return statement

[Noam Rosenthal]

Created attachment 136257 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136257 [details]
Patch for landing

Clearing flags on attachment: 136257

Committed r113615: <http://trac.webkit.org/changeset/113615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.